Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tables] Make integer default serialization 32bit #13420

Closed
annatisch opened this issue Aug 29, 2020 · 2 comments
Closed

[Tables] Make integer default serialization 32bit #13420

annatisch opened this issue Aug 29, 2020 · 2 comments
Assignees
@seankane-msft
Labels
Client This issue points to a problem in the data-plane of the library. Tables
Milestone
[2020] November

Comments

@annatisch
Copy link
Member

Currently the Tables SDK defaults an integer to serialize as 64bit. However this creates compatibility issues with the other languages - specifically JS, where this will be returned as a string.
We should behave consistently and use 32bit as the default.
This will mean:

  • We will need to write some tests to see what the error behaviour is for users providing a numeric value greater than the 32bit max
  • We should update any samples, docs etc to describe how to handle this error - i.e. the EntityProperty wrapper to specifying 64bit data type.
  • We could think about automatically using 64bit type for large integer values.... but not for first preview.
  • At some point we should set up some cross language compatbility tests, again, this can be post preview1.
@annatisch annatisch added Client This issue points to a problem in the data-plane of the library. Tables labels Aug 29, 2020
@seankane-msft seankane-msft self-assigned this Aug 31, 2020
@seankane-msft seankane-msft added this to the [2020] September milestone Aug 31, 2020
@seankane-msft seankane-msft mentioned this issue Aug 31, 2020
Merged
@seankane-msft
Copy link
Member

If the number is more than 64 bits, a TypeError is thrown stating that the value cannot be contained within. In this PR I address some of the above concerns.

@seankane-msft seankane-msft mentioned this issue Sep 9, 2020
Closed
@seankane-msft seankane-msft modified the milestones: [2020] October, nov, [2020] November Oct 7, 2020
@seankane-msft
Copy link
Member

@annatisch Do we want to change this to make integer serialization use Int64 if a number is larger than a 32 bit representation? If not I think we can close this issue.

@seankane-msft seankane-msft mentioned this issue Oct 28, 2020
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Apr 1, 2021
@norshtein @charlili1234
@charliedmcb @bowang-666 @bcho @haitch @MirzaSikander @JunSun17
CodeGen from PR 13737 in Azure/azure-rest-api-specs
b8c5d82 
Merge Dev-containerservice-microsoft.containerservice-2021-03-01 API to master  (Azure#13737)

* Adds base for updating Microsoft.ContainerService from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range (Azure#13349)

Co-authored-by: Charlie Li <charlili@microsoft.com>

* Add enableFIPS property to 2021-03-01 API in dev 2021-03-01 branch (Azure#13359)

* fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range

* Add enableFIPS property to the 2021-03-01 API

* Add enableFIPS property to the 2021-03-01 API

Co-authored-by: Charlie Li <charlili@microsoft.com>

* adding node-image upgrade channel enum (Azure#13375)

Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com>

* Add httpProxyConfig specs to 2021-03-01 API - dev (Azure#13410)

* Add httpProxyConfig specs to 2021-03-01 API - dev

* Fix prettier

* aks: add `bindingSelector` to managed cluster pod identity profile (Azure#13399)

* AKS runCommand new feature  (Azure#13420)

* runCommand target to 03-01

* fix api-version in examples

* Add property disableLocalAccounts to 2021-03-01 API version (Azure#13385)

* Add property disableLocalAccounts

* Fix indentation

* Add OSSKU and GPUInstanceProfile to containerservice/microsoft.container API 2021-03-01 (Azure#13532)

* Add OSSKU and GPUInstanceProfile

* Add sample for OSSKU and GPUInstanceProfile

* Fix custom words

* Reference sample files

* update custom-words

* Update readme for sdks  (Azure#13515)

* update readme for sdks

* update readme for sdks

Co-authored-by: Charlie Li <charlili@microsoft.com>

* Add example to create agent pool with FIPS enabled (Azure#13557)

* add example to create agent pool with FIPS enabled

* change a property name in the example file

Co-authored-by: Charlie Li <charlili@microsoft.com>

* Added extended location parameter to managed cluster which will target all agent pools to that extended location. (Azure#13560)

* Add data model for get OS options. (Azure#13619)

* Add data model for get OS options.

* Add default resource name in API path.

* Fix container service tags. (Azure#13739)

Co-authored-by: Tongyao Si <tosi@microsoft.com>
Co-authored-by: Charlie Li <charlili@microsoft.com>
Co-authored-by: Charlie McBride <33269602+charliedmcb@users.noreply.github.com>
Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com>
Co-authored-by: Bo Wang <61758179+bowang-666@users.noreply.github.com>
Co-authored-by: hbc <bcxxxxxx@gmail.com>
Co-authored-by: Haitao Chen <haitch@users.noreply.github.com>
Co-authored-by: Tony Xu <tonyxu@microsoft.com>
Co-authored-by: Mirza Sikander <mirsik@microsoft.com>
Co-authored-by: Jun Sun <33297523+JunSun17@users.noreply.github.com>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Apr 1, 2021
@norshtein @charlili1234
@charliedmcb @bowang-666 @bcho @haitch @MirzaSikander @JunSun17
CodeGen from PR 13737 in Azure/azure-rest-api-specs
9cd4fac 
Merge Dev-containerservice-microsoft.containerservice-2021-03-01 API to master  (Azure#13737)

* Adds base for updating Microsoft.ContainerService from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range (Azure#13349)

Co-authored-by: Charlie Li <charlili@microsoft.com>

* Add enableFIPS property to 2021-03-01 API in dev 2021-03-01 branch (Azure#13359)

* fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range

* Add enableFIPS property to the 2021-03-01 API

* Add enableFIPS property to the 2021-03-01 API

Co-authored-by: Charlie Li <charlili@microsoft.com>

* adding node-image upgrade channel enum (Azure#13375)

Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com>

* Add httpProxyConfig specs to 2021-03-01 API - dev (Azure#13410)

* Add httpProxyConfig specs to 2021-03-01 API - dev

* Fix prettier

* aks: add `bindingSelector` to managed cluster pod identity profile (Azure#13399)

* AKS runCommand new feature  (Azure#13420)

* runCommand target to 03-01

* fix api-version in examples

* Add property disableLocalAccounts to 2021-03-01 API version (Azure#13385)

* Add property disableLocalAccounts

* Fix indentation

* Add OSSKU and GPUInstanceProfile to containerservice/microsoft.container API 2021-03-01 (Azure#13532)

* Add OSSKU and GPUInstanceProfile

* Add sample for OSSKU and GPUInstanceProfile

* Fix custom words

* Reference sample files

* update custom-words

* Update readme for sdks  (Azure#13515)

* update readme for sdks

* update readme for sdks

Co-authored-by: Charlie Li <charlili@microsoft.com>

* Add example to create agent pool with FIPS enabled (Azure#13557)

* add example to create agent pool with FIPS enabled

* change a property name in the example file

Co-authored-by: Charlie Li <charlili@microsoft.com>

* Added extended location parameter to managed cluster which will target all agent pools to that extended location. (Azure#13560)

* Add data model for get OS options. (Azure#13619)

* Add data model for get OS options.

* Add default resource name in API path.

* Fix container service tags. (Azure#13739)

Co-authored-by: Tongyao Si <tosi@microsoft.com>
Co-authored-by: Charlie Li <charlili@microsoft.com>
Co-authored-by: Charlie McBride <33269602+charliedmcb@users.noreply.github.com>
Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com>
Co-authored-by: Bo Wang <61758179+bowang-666@users.noreply.github.com>
Co-authored-by: hbc <bcxxxxxx@gmail.com>
Co-authored-by: Haitao Chen <haitch@users.noreply.github.com>
Co-authored-by: Tony Xu <tonyxu@microsoft.com>
Co-authored-by: Mirza Sikander <mirsik@microsoft.com>
Co-authored-by: Jun Sun <33297523+JunSun17@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@seankane-msft seankane-msft

Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Milestone
[2020] November
Development

No branches or pull requests
2 participants
@annatisch @seankane-msft