Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please help add regression test runs for identity #12740

Closed
xiangyan99 opened this issue Jul 27, 2020 · 5 comments
Closed

Please help add regression test runs for identity #12740

xiangyan99 opened this issue Jul 27, 2020 · 5 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Comments

@xiangyan99
Copy link
Member

Now we have regression runs for azure-core.

Can we add the regression tests for identity as well?

What we want is to install latest bits and run tests against last GA release. So we can make sure we don't introduce breaking changes between two GA releases.

@xiangyan99 xiangyan99 added the EngSys This issue is impacting the engineering system. label Jul 27, 2020
@kurtzeborn kurtzeborn added the Central-EngSys This issue is owned by the Engineering System team. label Dec 3, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Feb 22, 2021
Default API version is now 2020-10-01 (Azure#12740)
@scbedd
Copy link
Member

scbedd commented Mar 15, 2023

  • azure-identity is checked against the latest azure-core and earliest azure-core in it's mindependency stage.
  • azure-core regression checks find the earliest and latest released version of azure-identity that match current azure-core and runs tests against them.

I think these are covered scenarios. Closing. Feel free to reopen if you want @xiangyan99.

@scbedd scbedd closed this as completed Mar 15, 2023
@xiangyan99
Copy link
Member Author

@scbedd what we are looking for is regression validation.

e.g. currently we install latest GAed identity and run storage tests.

What we want to validate is install the live identity from main and run those tests to catch breaking changes/regressions.

Do you know if we have such coverage in our current matrix?

Thanks.

@scbedd
Copy link
Member

scbedd commented Mar 17, 2023

What we want to validate is install the live identity from main and run those tests to catch breaking changes/regressions.

I laid out the two ways we test, can you give me a bit more detail about what you mean by regression?

What we want to validate is install the live identity from main and run those tests to catch breaking changes/regressions.

Doesn't the mindependency check do literally exactly this? Current identity from main (or your pr) running against earliest and latest azure-core that it can depend on?

@scbedd scbedd reopened this Mar 17, 2023
@scbedd
Copy link
Member

scbedd commented Mar 17, 2023

Had a chat with @xiangyan99 about this.

We need a new regression step that runs based on dev_requirements contents + actual dependencies.

This is a live test invocation, it has nothing to do with recorded tests.

One way we could recognize this is to check dev_requirements for any azure-* dependency.
if present, that is a package that should be regression tested.
A regression test means running live tests for that target using the identity from disk NOT PYPI

Copy link

Hi @xiangyan99, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

4 participants