Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBus - Track2 - Design/Add Callback Handler to autolockrenew #11761

Closed
KieranBrantnerMagee opened this issue Jun 2, 2020 · 1 comment
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Milestone

Comments

@KieranBrantnerMagee
Copy link
Member

Is your feature request related to a problem? Please describe.
Users consuming autolockrenew would like a more responsive mechanism to react to issues in lock renewal. (see #11611) This would cleanly mirror the pattern used in the processors of other language sdks (onError handlers)

Describe the solution you'd like
An onError callback parameter to autolockrenewal registration or creation to allow taking immediate action if renewal fails.

Describe alternatives you've considered
There are two approaches I see to this.

  1. put on the initial constructor, for all registered objects.
  2. Put on the "register" stanza. This seems like the right choice, as action for renewal failure on a session vs. a message are very different things and one may use lock renewal for both. (Technically we could accomplish this in the generic constructor by passing the entity in question as well; but it would then require instanceof, and that's a code smell to me)

Additional context
See GH thread linked above for further context.

@KieranBrantnerMagee KieranBrantnerMagee added feature-request This issue requires a new behavior in the product in order be resolved. Service Bus Client This issue points to a problem in the data-plane of the library. labels Jun 2, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the Backlog milestone Jun 2, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Jun 2, 2020
@KieranBrantnerMagee
Copy link
Member Author

This is completed per the associated PR above (#11740) Closing++

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Dec 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Projects
None yet
Development

No branches or pull requests

1 participant