Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IotHub Quickstart sample to use latest Event Hubs SDK #11289

Closed
ramya-rao-a opened this issue May 7, 2020 · 1 comment
Closed

Update IotHub Quickstart sample to use latest Event Hubs SDK #11289

ramya-rao-a opened this issue May 7, 2020 · 1 comment
Assignees
@YijunXieMS
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone
[2020] July

Comments

@ramya-rao-a
Copy link
Contributor

https://github.com/Azure-Samples/azure-iot-samples-python is the Python samples repo for IotHub. The read-d2c-messages folder is meant to contain sample that shows how to use the Event Hubs package to get events sent to IotHub.

Previously, this contained a link to the older event hub repo whose sample code would not work with the latest event hubs package and thus confusing users. I fixed that with Azure-Samples/azure-iot-samples-python#23 as a temporary stop gap to avoid users from being mislead.

This issue is to track the follow up work needed to update the samples repo with a real sample just like we did for node in Azure-Samples/azure-iot-samples-node#39

Please try and follow a similar model i.e

  • The sample should use Event Hubs compatible connection string
  • The sample should also show how to use websockets and proxy support, but should be commented out
  • The readme should talk about how to form the Event Hubs compatible connection string, the back up option to use our IotHub to EH compatible conversion sample, checkpointing and websocket/proxy support
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 7, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Event Hubs labels May 7, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 7, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] June milestone May 7, 2020
@lmazuel lmazuel modified the milestones: [2020] June, [2020] July Jun 9, 2020
@YijunXieMS
Copy link
Contributor

It's merged

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 11, 2021
CodeGen from PR 11289 in Azure/azure-rest-api-specs
c562eca 
[Hub Generated] Review request for Microsoft.DataLakeAnalytics to add version preview/2015-10-01-preview (Azure#11289)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* build failue fix

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Validation issue fix

* Removing example JSON file is not referenced from the swagger file

* Prettier Error Fix

* Prettier Check fixes

* typo fix and Removed breaking changes for Readonly field

* Validation issue fix

* prettier error fix

* Reverting Readonly propertly fix

* Semantic Validation fix

* Semantic Validation fix

* BreakingChange fix for 2015 preview version

* ReadonlyPropertyChanged

* ReadonlyPropertyChanged Fix

* Swagger SemanticValidation failed Fix

* prettier check fix

* Fixing swagger issues

* fixed model validation errors

* Review feedback fix and adding default response

* lint diff tool fixes

* Removed Error codes and defaulted error response

* Prettier  fixes

* breaking changes and sdk failure fixes

* prettier fix

* fixing merge conflicts

* swagger lintdiff fixes

* breaking changes fix

* prettier fix

* Update custom-words.txt

* piepline Error Fix

* Path fixed

* duplicate path fix

* Removed duplicate paths

* Lintdiff fixes

* lint diff fixes for list schema

* code review comments

* Swagger Model Validation Failure Fix

* prettier fix

Co-authored-by: Sravan Thupili <srthupil@microsoft.com>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 11, 2021
CodeGen from PR 11289 in Azure/azure-rest-api-specs
634054f 
[Hub Generated] Review request for Microsoft.DataLakeAnalytics to add version preview/2015-10-01-preview (Azure#11289)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* build failue fix

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Issue 8189082: Swagger Correctness: MICROSOFT.DATALAKEANALYTICS(null)

* Validation issue fix

* Removing example JSON file is not referenced from the swagger file

* Prettier Error Fix

* Prettier Check fixes

* typo fix and Removed breaking changes for Readonly field

* Validation issue fix

* prettier error fix

* Reverting Readonly propertly fix

* Semantic Validation fix

* Semantic Validation fix

* BreakingChange fix for 2015 preview version

* ReadonlyPropertyChanged

* ReadonlyPropertyChanged Fix

* Swagger SemanticValidation failed Fix

* prettier check fix

* Fixing swagger issues

* fixed model validation errors

* Review feedback fix and adding default response

* lint diff tool fixes

* Removed Error codes and defaulted error response

* Prettier  fixes

* breaking changes and sdk failure fixes

* prettier fix

* fixing merge conflicts

* swagger lintdiff fixes

* breaking changes fix

* prettier fix

* Update custom-words.txt

* piepline Error Fix

* Path fixed

* duplicate path fix

* Removed duplicate paths

* Lintdiff fixes

* lint diff fixes for list schema

* code review comments

* Swagger Model Validation Failure Fix

* prettier fix

Co-authored-by: Sravan Thupili <srthupil@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@YijunXieMS YijunXieMS

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
[2020] July
Development

No branches or pull requests
3 participants
@lmazuel @ramya-rao-a @YijunXieMS