[metricsadvisor] fix sample/readme issues (#15854)

Resolves #15845
Azure · Dec 17, 2020 · 7368ddf · 7368ddf
1 parent 5792b5b
commit 7368ddf
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/sdk/metricsadvisor/azure-ai-metricsadvisor/README.md b/sdk/metricsadvisor/azure-ai-metricsadvisor/README.md
@@ -116,6 +116,8 @@ Metrics Advisor lets you create and subscribe to real-time alerts. These alerts
 Metrics Advisor supports connecting different types of data sources. Here is a sample to ingest data from SQL Server.
 
 ```py
+import os
+import datetime
 from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential, MetricsAdvisorAdministrationClient
 from azure.ai.metricsadvisor.models import (
         SQLServerDataFeed,
@@ -124,6 +126,7 @@ from azure.ai.metricsadvisor.models import (
         DataFeedDimension,
         DataFeedOptions,
         DataFeedRollupSettings,
+        DataFeedMissingDataPointFillSettings
     )
 
 service_endpoint = os.getenv("ENDPOINT")
@@ -410,7 +413,6 @@ for result in results:
 We can also query the root causes of an incident
 
 ```py
-import datetime
 from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential, MetricsAdvisorClient
 
 service_endpoint = os.getenv("ENDPOINT")

diff --git a/...advisor/azure-ai-metricsadvisor/samples/async_samples/sample_alert_configuration_async.py b/...advisor/azure-ai-metricsadvisor/samples/async_samples/sample_alert_configuration_async.py
@@ -315,7 +315,7 @@ async def main():
     print("\n---List anomaly alert configurations...")
     await sample_list_alert_configs_async()
     print("\n---Query anomaly detection results...")
-    alerts = await sample_list_alerts_async()
+    alerts = await sample_list_alerts_async(alert_config.id)
     if len(alerts) > 0:
         print("\n---Query anomalies using alert id...")
         alert_id = alerts[0].id

diff --git a/...tricsadvisor/azure-ai-metricsadvisor/samples/async_samples/sample_authentication_async.py b/...tricsadvisor/azure-ai-metricsadvisor/samples/async_samples/sample_authentication_async.py
@@ -40,7 +40,7 @@ async def authentication_client_with_metrics_advisor_credential_async():
     # [END authentication_client_with_metrics_advisor_credential_async]
 
 
-def authentication_administration_client_with_metrics_advisor_credential_async():
+async def authentication_administration_client_with_metrics_advisor_credential_async():
     # [START administration_client_with_metrics_advisor_credential_async]
     from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential
     from azure.ai.metricsadvisor.aio import MetricsAdvisorAdministrationClient

diff --git a/sdk/metricsadvisor/azure-ai-metricsadvisor/samples/async_samples/sample_feedback_async.py b/sdk/metricsadvisor/azure-ai-metricsadvisor/samples/async_samples/sample_feedback_async.py
@@ -73,7 +73,8 @@ async def sample_add_feedback_async():
 
 async def sample_get_feedback_async():
     # [START get_feedback_async]
-    from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential, MetricsAdvisorClient
+    from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential
+    from azure.ai.metricsadvisor.aio import MetricsAdvisorClient
 
     service_endpoint = os.getenv("METRICS_ADVISOR_ENDPOINT")
     subscription_key = os.getenv("METRICS_ADVISOR_SUBSCRIPTION_KEY")
@@ -90,7 +91,8 @@ async def sample_get_feedback_async():
 
 async def sample_list_feedback_async():
     # [START list_feedback_async]
-    from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential, MetricsAdvisorClient
+    from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential
+    from azure.ai.metricsadvisor.aio import MetricsAdvisorClient
 
     service_endpoint = os.getenv("METRICS_ADVISOR_ENDPOINT")
     subscription_key = os.getenv("METRICS_ADVISOR_SUBSCRIPTION_KEY")

diff --git a/sdk/metricsadvisor/azure-ai-metricsadvisor/samples/sample_alert_configuration.py b/sdk/metricsadvisor/azure-ai-metricsadvisor/samples/sample_alert_configuration.py
@@ -188,11 +188,13 @@ def sample_list_alerts(alert_config_id):
         end_time=datetime.datetime(2020, 9, 9),
         time_mode="AnomalyTime",
     )
+
+    tolist = []
     for result in results:
+        tolist.append(result)
         print("Alert id: {}".format(result.id))
         print("Create on: {}".format(result.created_on))
-    return results
-
+    return tolist
     # [END list_alerts]