[AutoPR recoveryservicessiterecovery/resource-manager] [Hub Generated] Review request: Enhanced A2AEnableProtectionInput & A2AReplicationDetails

lib/services/recoveryServicesSiteRecoveryManagement/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2018 Microsoft
+Copyright (c) 2019 Microsoft
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

lib/services/recoveryServicesSiteRecoveryManagement/README.md

@@ -3,41 +3,41 @@ uid: azure-arm-recoveryservices-siterecovery
 summary: *content
 
 ---
-# Microsoft Azure SDK for Node.js - SiteRecoveryManagementClient
+**This SDK will be deprecated next year and will be replaced by a new TypeScript-based isomorphic SDK (found at https://github.com/Azure/azure-sdk-for-js) which works on Node.js and browsers.**
+## Microsoft Azure SDK for Node.js - SiteRecoveryManagementClient
+
 This project provides a Node.js package for accessing Azure. Right now it supports:
 - **Node.js version 6.x.x or higher**
 
-## Features
+### Features
 
 
-## How to Install
+### How to Install
 
 ```bash
 npm install azure-arm-recoveryservices-siterecovery
 ```
 
-## How to use
+### How to use
 
-### Authentication, client creation and list operations as an example.
+#### Authentication, client creation, and list operations as an example.
 
 ```javascript
 const msRestAzure = require("ms-rest-azure");
 const SiteRecoveryManagementClient = require("azure-arm-recoveryservices-siterecovery");
 msRestAzure.interactiveLogin().then((creds) => {
-    const subscriptionId = "<Subscription_Id>";
-    const client = new SiteRecoveryManagementClient(creds, subscriptionId);
-    return client.operations.list().then((result) => {
-      console.log("The result is:");
-      console.log(result);
-    });
+  const subscriptionId = "<Subscription_Id>";
+  const client = new SiteRecoveryManagementClient(creds, subscriptionId);
+
+  return client.operations.list().then((result) => {
+    console.log("The result is:");
+    console.log(result);
+  });
 }).catch((err) => {
   console.log('An error occurred:');
   console.dir(err, {depth: null, colors: true});
 });
-
-## Related projects
+```
+### Related projects
 
 - [Microsoft Azure SDK for Node.js](https://github.com/Azure/azure-sdk-for-node)
-
-
-![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-node%2Flib%2Fservices%2FrecoveryServicesSiteRecoveryManagement%2FREADME.png)

lib/services/recoveryServicesSiteRecoveryManagement/lib/models/a2AAddDisksInput.js

@@ -0,0 +1,93 @@
+/*
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License. See License.txt in the project root for
+ * license information.
+ *
+ * Code generated by Microsoft (R) AutoRest Code Generator.
+ * Changes may cause incorrect behavior and will be lost if the code is
+ * regenerated.
+ */
+
+'use strict';
+
+const models = require('./index');
+
+/**
+ * A2A add disk(s) input.
+ *
+ * @extends models['AddDisksProviderSpecificInput']
+ */
+class A2AAddDisksInput extends models['AddDisksProviderSpecificInput'] {
+  /**
+   * Create a A2AAddDisksInput.
+   * @property {array} [vmDisks] The list of vm disk details.
+   * @property {array} [vmManagedDisks] The list of vm managed disk details.
+   */
+  constructor() {
+    super();
+  }
+
+  /**
+   * Defines the metadata of A2AAddDisksInput
+   *
+   * @returns {object} metadata of A2AAddDisksInput
+   *
+   */
+  mapper() {
+    return {
+      required: false,
+      serializedName: 'A2A',
+      type: {
+        name: 'Composite',
+        polymorphicDiscriminator: {
+          serializedName: 'instanceType',
+          clientName: 'instanceType'
+        },
+        uberParent: 'AddDisksProviderSpecificInput',
+        className: 'A2AAddDisksInput',
+        modelProperties: {
+          instanceType: {
+            required: true,
+            serializedName: 'instanceType',
+            isPolymorphicDiscriminator: true,
+            type: {
+              name: 'String'
+            }
+          },
+          vmDisks: {
+            required: false,
+            serializedName: 'vmDisks',
+            type: {
+              name: 'Sequence',
+              element: {
+                  required: false,
+                  serializedName: 'A2AVmDiskInputDetailsElementType',
+                  type: {
+                    name: 'Composite',
+                    className: 'A2AVmDiskInputDetails'
+                  }
+              }
+            }
+          },
+          vmManagedDisks: {
+            required: false,
+            serializedName: 'vmManagedDisks',
+            type: {
+              name: 'Sequence',
+              element: {
+                  required: false,
+                  serializedName: 'A2AVmManagedDiskInputDetailsElementType',
+                  type: {
+                    name: 'Composite',
+                    className: 'A2AVmManagedDiskInputDetails'
+                  }
+              }
+            }
+          }
+        }
+      }
+    };
+  }
+}
+
+module.exports = A2AAddDisksInput;

lib/services/recoveryServicesSiteRecoveryManagement/lib/models/a2AContainerMappingInput.js

@@ -20,9 +20,9 @@ const models = require('./index');
 class A2AContainerMappingInput extends models['ReplicationProviderSpecificContainerMappingInput'] {
   /**
    * Create a A2AContainerMappingInput.
-   * @member {string} [agentAutoUpdateStatus] A value indicating whether the
+   * @property {string} [agentAutoUpdateStatus] A value indicating whether the
    * auto update is enabled. Possible values include: 'Disabled', 'Enabled'
-   * @member {string} [automationAccountArmId] The automation account arm id.
+   * @property {string} [automationAccountArmId] The automation account arm id.
    */
   constructor() {
     super();

lib/services/recoveryServicesSiteRecoveryManagement/lib/models/a2AEnableProtectionInput.js

@@ -20,37 +20,42 @@ const models = require('./index');
 class A2AEnableProtectionInput extends models['EnableProtectionProviderSpecificInput'] {
   /**
    * Create a A2AEnableProtectionInput.
-   * @member {string} [fabricObjectId] The fabric specific object Id of the
+   * @property {string} [fabricObjectId] The fabric specific object Id of the
    * virtual machine.
-   * @member {string} [recoveryContainerId] The recovery container Id.
-   * @member {string} [recoveryResourceGroupId] The recovery resource group Id.
-   * Valid for V2 scenarios.
-   * @member {string} [recoveryCloudServiceId] The recovery cloud service Id.
+   * @property {string} [recoveryContainerId] The recovery container Id.
+   * @property {string} [recoveryResourceGroupId] The recovery resource group
+   * Id. Valid for V2 scenarios.
+   * @property {string} [recoveryCloudServiceId] The recovery cloud service Id.
    * Valid for V1 scenarios.
-   * @member {string} [recoveryAvailabilitySetId] The recovery availability set
-   * Id.
-   * @member {array} [vmDisks] The list of vm disk details.
-   * @member {array} [vmManagedDisks] The list of vm managed disk details.
-   * @member {string} [multiVmGroupName] The multi vm group name.
-   * @member {string} [recoveryBootDiagStorageAccountId] The boot diagnostic
+   * @property {string} [recoveryAvailabilitySetId] The recovery availability
+   * set Id.
+   * @property {array} [vmDisks] The list of vm disk details.
+   * @property {array} [vmManagedDisks] The list of vm managed disk details.
+   * @property {string} [multiVmGroupName] The multi vm group name.
+   * @property {string} [recoveryBootDiagStorageAccountId] The boot diagnostic
    * storage account.
-   * @member {object} [diskEncryptionInfo] The recovery disk encryption
+   * @property {object} [diskEncryptionInfo] The recovery disk encryption
    * information.
-   * @member {object} [diskEncryptionInfo.diskEncryptionKeyInfo] The recovery
+   * @property {object} [diskEncryptionInfo.diskEncryptionKeyInfo] The recovery
    * KeyVault reference for secret.
-   * @member {string}
-   * [diskEncryptionInfo.diskEncryptionKeyInfo.secretIdentifier] The secret url
+   * @property {string}
+   * [diskEncryptionInfo.diskEncryptionKeyInfo.secretIdentifier] The secret url
    * / identifier.
-   * @member {string}
+   * @property {string}
    * [diskEncryptionInfo.diskEncryptionKeyInfo.keyVaultResourceArmId] The
    * KeyVault resource ARM id for secret.
-   * @member {object} [diskEncryptionInfo.keyEncryptionKeyInfo] The recovery
+   * @property {object} [diskEncryptionInfo.keyEncryptionKeyInfo] The recovery
    * KeyVault reference for key.
-   * @member {string} [diskEncryptionInfo.keyEncryptionKeyInfo.keyIdentifier]
-   * The key url / identifier.
-   * @member {string}
+   * @property {string} [diskEncryptionInfo.keyEncryptionKeyInfo.keyIdentifier]
+   * The key url / identifier.
+   * @property {string}
    * [diskEncryptionInfo.keyEncryptionKeyInfo.keyVaultResourceArmId] The
    * KeyVault resource ARM id for key.
+   * @property {string} [recoveryAvailabilityZone] The recovery availability
+   * zone.
+   * @property {string} [recoveryAzureNetworkId] The recovery Azure virtual
+   * network ARM id.
+   * @property {string} [recoverySubnetName] The recovery subnet name.
    */
   constructor() {
     super();
@@ -169,6 +174,27 @@ class A2AEnableProtectionInput extends models['EnableProtectionProviderSpecificI
               name: 'Composite',
               className: 'DiskEncryptionInfo'
             }
+          },
+          recoveryAvailabilityZone: {
+            required: false,
+            serializedName: 'recoveryAvailabilityZone',
+            type: {
+              name: 'String'
+            }
+          },
+          recoveryAzureNetworkId: {
+            required: false,
+            serializedName: 'recoveryAzureNetworkId',
+            type: {
+              name: 'String'
+            }
+          },
+          recoverySubnetName: {
+            required: false,
+            serializedName: 'recoverySubnetName',
+            type: {
+              name: 'String'
+            }
           }
         }
       }

lib/services/recoveryServicesSiteRecoveryManagement/lib/models/a2AEventDetails.js

@@ -20,12 +20,12 @@ const models = require('./index');
 class A2AEventDetails extends models['EventProviderSpecificDetails'] {
   /**
    * Create a A2AEventDetails.
-   * @member {string} [protectedItemName] The protected item arm name.
-   * @member {string} [fabricObjectId] The azure vm arm id.
-   * @member {string} [fabricName] Fabric arm name.
-   * @member {string} [fabricLocation] The fabric location.
-   * @member {string} [remoteFabricName] Remote fabric arm name.
-   * @member {string} [remoteFabricLocation] Remote fabric location.
+   * @property {string} [protectedItemName] The protected item arm name.
+   * @property {string} [fabricObjectId] The azure vm arm id.
+   * @property {string} [fabricName] Fabric arm name.
+   * @property {string} [fabricLocation] The fabric location.
+   * @property {string} [remoteFabricName] Remote fabric arm name.
+   * @property {string} [remoteFabricLocation] Remote fabric location.
    */
   constructor() {
     super();

lib/services/recoveryServicesSiteRecoveryManagement/lib/models/a2AFailoverProviderInput.js

@@ -20,10 +20,10 @@ const models = require('./index');
 class A2AFailoverProviderInput extends models['ProviderSpecificFailoverInput'] {
   /**
    * Create a A2AFailoverProviderInput.
-   * @member {string} [recoveryPointId] The recovery point id to be passed to
+   * @property {string} [recoveryPointId] The recovery point id to be passed to
    * failover to a particular recovery point. In case of latest recovery point,
    * null should be passed.
-   * @member {string} [cloudServiceCreationOption] A value indicating whether
+   * @property {string} [cloudServiceCreationOption] A value indicating whether
    * to use recovery cloud service for TFO or not.
    */
   constructor() {

lib/services/recoveryServicesSiteRecoveryManagement/lib/models/a2APolicyCreationInput.js

@@ -20,13 +20,13 @@ const models = require('./index');
 class A2APolicyCreationInput extends models['PolicyProviderSpecificInput'] {
   /**
    * Create a A2APolicyCreationInput.
-   * @member {number} [recoveryPointHistory] The duration in minutes until
+   * @property {number} [recoveryPointHistory] The duration in minutes until
    * which the recovery points need to be stored.
-   * @member {number} [crashConsistentFrequencyInMinutes] The crash consistent
+   * @property {number} [crashConsistentFrequencyInMinutes] The crash
+   * consistent snapshot frequency (in minutes).
+   * @property {number} [appConsistentFrequencyInMinutes] The app consistent
    * snapshot frequency (in minutes).
-   * @member {number} [appConsistentFrequencyInMinutes] The app consistent
-   * snapshot frequency (in minutes).
-   * @member {string} multiVmSyncStatus A value indicating whether multi-VM
+   * @property {string} multiVmSyncStatus A value indicating whether multi-VM
    * sync has to be enabled. Value should be 'Enabled' or 'Disabled'. Possible
    * values include: 'Enable', 'Disable'
    */

lib/services/recoveryServicesSiteRecoveryManagement/lib/models/a2APolicyDetails.js

@@ -20,16 +20,16 @@ const models = require('./index');
 class A2APolicyDetails extends models['PolicyProviderSpecificDetails'] {
   /**
    * Create a A2APolicyDetails.
-   * @member {number} [recoveryPointThresholdInMinutes] The recovery point
+   * @property {number} [recoveryPointThresholdInMinutes] The recovery point
    * threshold in minutes.
-   * @member {number} [recoveryPointHistory] The duration in minutes until
+   * @property {number} [recoveryPointHistory] The duration in minutes until
    * which the recovery points need to be stored.
-   * @member {number} [appConsistentFrequencyInMinutes] The app consistent
+   * @property {number} [appConsistentFrequencyInMinutes] The app consistent
    * snapshot frequency in minutes.
-   * @member {string} [multiVmSyncStatus] A value indicating whether multi-VM
+   * @property {string} [multiVmSyncStatus] A value indicating whether multi-VM
    * sync has to be enabled.
-   * @member {number} [crashConsistentFrequencyInMinutes] The crash consistent
-   * snapshot frequency in minutes.
+   * @property {number} [crashConsistentFrequencyInMinutes] The crash
+   * consistent snapshot frequency in minutes.
    */
   constructor() {
     super();