This repository has been archived by the owner on May 5, 2023. It is now read-only.
[AutoPR network/resource-manager] Merge Network-2018-02-01 to Master Networking Swagger Changes for Feb 2018 #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs into Network-2018-02-01
Fixed operationIds for non-CRUD operations in ExpressRouteCrossConnections (#2720)
10 tasks
ghost
reviewed
Mar 22, 2018
| * @member {string} [type] The resource type of the key vault. | ||
| * @member {string} location The supported Azure location where the key vault | ||
| * should be created. | ||
| * @member {object} [tags] The tags that will be assigned to the key vault. | ||
| */ | ||
| export interface Resource extends BaseResource { | ||
| readonly id?: string; | ||
| name: string; | ||
| readonly name?: string; |
There was a problem hiding this comment.
Marking an existing interface property as readonly is a breaking change. Requires major version increment.
| @@ -2484,7 +2544,6 @@ export interface RouteFilterRule extends SubResource { | |||
| name?: string; | |||
| location?: string; | |||
| readonly etag?: string; | |||
| tags?: { [propertyName: string]: string }; | |||
There was a problem hiding this comment.
Removing an interface property is a breaking change. Requires a major version increment.
| */ | ||
| export interface PatchRouteFilterRule extends SubResource { | ||
| access: string; | ||
| communities: string[]; | ||
| readonly provisioningState?: string; | ||
| readonly name?: string; | ||
| readonly etag?: string; | ||
| tags?: { [propertyName: string]: string }; |
There was a problem hiding this comment.
Removing an interface property is a breaking change. Requires major version increment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to sync Azure/azure-rest-api-specs#2642