[Azure Search][Preview] Stabilize state of feature/search/preview branch #8450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arv100kri
requested review from
chidozieononiwu,
danieljurek,
erich-wang and
mitchdenny
as code owners
bleroy
reviewed
Oct 25, 2019
...onWithCustomerManagedKeysTests/CreateIndexWithCustomerManagedKeysUsingAccessCredentials.json
Show resolved
Hide resolved
added 9 commits
October 28, 2019 11:29
arv100kri
force-pushed
the
arv100kri/search-preview
branch
from
21f73e1 to
11da0d5
Compare
|
Need to add session records for all tests, not just the tests that I added. |
Fixed with a recent commit. Will check-in if the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature/search/previewis going to be the (temporary) ship vehicle for an eventual preview SDK for Azure search (tentatively 11.0.0-preview)This commit does the following:
2017-11-11-Preview(and will be in2019-05-06-Preview) but not in2019-05-06. The only notable change is customer managed encrypted indexes/synonym mapsThis is not the final version of the preview SDK - we intend to add features (via the swagger spec, to keep it in sync with the REST API). We intend to remove some deprecated types as well.
This PR, sets us up to allow that to happen.
(Optionally) after this PR is checked in, the branch
search-previewcan be eliminated.