Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Databox] SDK refresh to support new API version (2019-09-01) #8219

Merged
merged 10 commits into from
Oct 23, 2019

Conversation

sashanm
Copy link
Contributor

@sashanm sashanm commented Oct 18, 2019

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sashanm
Copy link
Contributor Author

sashanm commented Oct 18, 2019

@isra-fel : I closed PR #8176 since it was showing others commit as well somehow. so, I have created a new PR and addressed your code review comments in it. Please take a look and let me know If you have any concerns

Thanks

@isra-fel isra-fel closed this Oct 21, 2019
@isra-fel isra-fel reopened this Oct 21, 2019
@isra-fel isra-fel self-assigned this Oct 21, 2019
@@ -7,23 +7,20 @@
<PackageId>Microsoft.Azure.Management.DataBox</PackageId>
<Description>Microsoft Azure Management DataBox library</Description>
<AssemblyName>Microsoft.Azure.Management.DataBox</AssemblyName>
<Version>1.0.1</Version>
<Version>1.2.0</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, please use 1.1.0

@@ -8,7 +8,7 @@
[assembly: AssemblyDescription("Provides Microsoft Azure DataBox management functions for managing the Microsoft Azure DataBox service.")]

[assembly: AssemblyVersion("1.0.0")]
[assembly: AssemblyFileVersion("1.0.1")]
[assembly: AssemblyFileVersion("1.2.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-revision and removed needs-review labels Oct 21, 2019
@isra-fel isra-fel assigned sashanm and unassigned isra-fel Oct 21, 2019
@sashanm sashanm removed their assignment Oct 22, 2019
@sashanm sashanm removed their assignment Oct 22, 2019
@isra-fel isra-fel merged commit 4bee048 into Azure:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants