Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Container to BlobContainer #7865

Merged
merged 6 commits into from
Oct 3, 2019

Conversation

JoshLove-msft
Copy link
Member

Fixes #7835

Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a quick Find All in Visual Studio for (?<!Blob)Container using case sensitivity and regexes in your *.cs files?

@JoshLove-msft
Copy link
Member Author

/azp run net - storage - ci

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@JoshLove-msft JoshLove-msft force-pushed the blob-container-rename branch 2 times, most recently from e1fc8f1 to 083c875 Compare October 2, 2019 21:23
Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

FYI @seanmcc-msft and @amnguye - I'd like to merge this today so it'll cause as few conflicts as possible. Mind taking a quick skim? It's a very mechanical global rename per API Review feedback.

@JoshLove-msft
Copy link
Member Author

/azp run net - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft JoshLove-msft merged commit e70ca70 into Azure:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: Make sure Container is always written BlobContainer
3 participants