Concurrency supported in Smoke Tests #7169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performs functionalities with Key Vault, Identity, Event Hubs and Blob Storage Track 2 SDKs.
The names were changed to match the name convention for environment variables.
A gitignore file was created in the SmokeTest folder, and now all launchSettings.json files are being ignored.
Work based on the reviews from the PR #6652. The public methods are now in PascalCase, the methods does not longer return English strings, instead they return booleans or Exceptions. And Exit Codes handling was implemented.
Class names were changed to match the following pattern: <service>Test. Example: BlobStorage -> BlobStorageTest.
Use of higher order functions to dry up the code.
Drying up the code by using high order functions.
Tests done with Mirosoft.Azure.DocumentDB SDK.
The samples not longer need the "TestBase" class to run.
This text file is not going to be needed any more since the test Blob is being created within the code.
All classes are now static.
danieljurek
approved these changes
Aug 7, 2019
danieljurek
approved these changes
Aug 8, 2019
danieljurek
reviewed
Aug 8, 2019
pull bot
pushed a commit
to test-repo-billy/azure-sdk-for-net
that referenced
this pull request
Aug 8, 2019
* .NET smoke Test Sample Performs functionalities with Key Vault, Identity, Event Hubs and Blob Storage Track 2 SDKs. * Env Variables names changed The names were changed to match the name convention for environment variables. * Update .gitignore * gitignore updated A gitignore file was created in the SmokeTest folder, and now all launchSettings.json files are being ignored. * Exit Codes, PascalCase and refactoring of the static methods. Work based on the reviews from the PR Azure#6652. The public methods are now in PascalCase, the methods does not longer return English strings, instead they return booleans or Exceptions. And Exit Codes handling was implemented. * Class names changed Class names were changed to match the following pattern: <service>Test. Example: BlobStorage -> BlobStorageTest. * Comments XML comments were added and some unnecesary comments were deleted. * Higher order functions Use of higher order functions to dry up the code. * Test classes refactured Drying up the code by using high order functions. * Create CosmosDBTest.cs * Cosmos DB implementation Tests done with Mirosoft.Azure.DocumentDB SDK. * Update CosmosDBTest.cs * Update CosmosDBTest.cs * Unnecessary blank lines removed * ExecuteTest typo * Base class deleted The samples not longer need the "TestBase" class to run. * BlobTestSource.tst deleted This text file is not going to be needed any more since the test Blob is being created within the code. * Static Classes All classes are now static. * Pair programming comments * Concurrency support * License headers added * License header added * Adapted for concurrency * Use of string interpolation * Use of string interpolation * Update EventHubsTest.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A random UUID was added to the objects in order to support various instances of the smoke tests running simultaneously without interfering each other's resources.
For Key Vault - Secrets, the random UUID was added at the end of the secret-name.
For Storage - Blob, it was added in the blob-name.
For Cosmos DB, it was added at the end of the database-name
For Event Hubs, there is no need to add this random uuid.
Also, the license headers were added to the files.