[Azure Search] Add URL encode + decode field mapping functions #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Careyjmac
approved these changes
Aug 6, 2019
brjohnstmsft
suggested changes
Aug 6, 2019
There was a problem hiding this comment.
We should find a platform-independent way to describe the functionality of these field mapping functions. While in this case it's .NET developers reading the docs, what about for our future Java SDK? I would argue we shouldn't be leaking implementation details of our REST API in SDK docs.
...zure.Search.Service/src/Customizations/Indexers/Models/FieldMappingFunction.Customization.cs
Outdated
Show resolved
Hide resolved
...zure.Search.Service/src/Customizations/Indexers/Models/FieldMappingFunction.Customization.cs
Outdated
Show resolved
Hide resolved
Fixed in the latest commit! |
brjohnstmsft
approved these changes
Aug 6, 2019
pull bot
pushed a commit
to test-repo-billy/azure-sdk-for-net
that referenced
this pull request
Aug 8, 2019
…#7126) * Add URL encode + decode mapping functions * Update tests * Update session records for all IndexerTests * Update doc comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
urlEncodeandurlDecodefield mapping functions, that were recently added to the back end service. These are not swagger reliant and are wholly introduced via customizations