[Azure Search] Fix the definition of WebApiSkill #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Careyjmac
suggested changes
Aug 1, 2019
sdk/search/Microsoft.Azure.Search/tests/Tests/SkillsetsTests.cs
Outdated
Show resolved
Hide resolved
Careyjmac
approved these changes
Aug 2, 2019
brjohnstmsft
suggested changes
Aug 5, 2019
sdk/search/Microsoft.Azure.Search/tests/Tests/SkillsetsTests.cs
Outdated
Show resolved
Hide resolved
@Careyjmac and I have added extra context in the thread. Let me know what you think |
brjohnstmsft
approved these changes
Aug 5, 2019
|
LGTM... preceding version bump looks good as well given this is a breaking change. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This SDK was generated based on this completed pull request in the swagger repository.
This pull request, intends to correct the definition of the
WebApiSkillmodel in the SDK, by making headers a simple dictionary within the skill and not a nested property.Added a test to ensure correctness
This is a breaking change, and is already preceeded by a version bump in this PR
Fixes #6468