Move async collection to core #7038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tg-msft
approved these changes
Jul 29, 2019
| /// iterate over. | ||
| /// </summary> | ||
| /// <typeparam name="T">The type of the values.</typeparam> | ||
| public abstract class AsyncCollection<T> : IAsyncEnumerable<Response<T>> |
There was a problem hiding this comment.
Open question - are we going to have a SyncCollection<T> or similar as an indicator to customers that the sync version of GetBlobs() may make 100 requests?
| /// <summary> | ||
| /// Gets the values in this <see cref="Page{T}"/>. | ||
| /// </summary> | ||
| public IReadOnlyList<T> Values { get; } |
There was a problem hiding this comment.
Open question - we've got open issues like #6894 to use T[] (rather than IEnumerable<T> or IReadOnlyList<T>) and it'd be great to be consistent.
tg-msft
reviewed
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6807
I also cleaned up some todos:
Values seem fine considering
Response.ValueI doubt we ever going to lazily deserialize items and the array is easy to consume unfortunately it's mutable so I've picked
IReadOnlyListas a middle ground.I think it would add complexity around serializing it into a string that would fall onto customers. Keeping as a string.