Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate new sql client form swagger containing instance pools and usages changes. #6857

Merged
merged 3 commits into from
Jul 12, 2019

Conversation

johnpaulkee
Copy link
Contributor

Generated new sql client which adds new instance pool and usages changes.
Tests have been recorded showing its end to end usage.

An instance pool is a “resource container” or a set pre-allocated virtual machines organized in an isolated private cluster.
Azure SQL managed instances will be able to be provisioned and deployed within an instance pool and consume it’s allocated capacity.

@erich-wang
Copy link
Member

@johnpaulkee

  1. Please follow step 8 in instruction. It will really help us a lot to review your PR if it contains sdk_metadata<rpName>.txt which is generated by generate.ps1

  2. Please update Version and PackageReleaseNotes in your csproj file

@johnpaulkee
Copy link
Contributor Author

Sure thing @erich-wang. Thanks for providing links to instructions.
I’ll go ahead and make those updates when possible.

@johnpaulkee
Copy link
Contributor Author

Hi @erich-wang, I've gone ahead and updated the review based on your feedback.
Thank you.

@erich-wang erich-wang merged commit 974c579 into Azure:master Jul 12, 2019
@johnpaulkee
Copy link
Contributor Author

Thanks @erich-wang !

rileymckenna pushed a commit to rileymckenna/azure-sdk-for-net that referenced this pull request Jul 16, 2019
…ages changes. (Azure#6857)

* initialize instance pool .net sdk client and recorded tests

* Update version and package release notes, added sql_resource_manager.txt to eng/mgmt/mgmtmetadata as per instructions

* Update sql_resource_manager.txt file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants