Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent pump from stop processing by ignoring ObjectDisposedException #6510

Closed
wants to merge 1 commit into from
Closed

Prevent pump from stop processing by ignoring ObjectDisposedException #6510

wants to merge 1 commit into from

Conversation

petrformanek
Copy link

Description

Fix for issue 687.

@msftclas
Copy link

msftclas commented Jun 7, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@petrformanek
Copy link
Author

Hello @axisc can anybody approve this PR?

@ramya-rao-a ramya-rao-a requested a review from binzywu June 28, 2019 01:15
@ramya-rao-a
Copy link
Contributor

@binzywu, Can you have someone from your team take a look at this PR?

@ramya-rao-a
Copy link
Contributor

@binzywu Assigning you as the reviewer for now, let me know if you want to move it to anyone else.
cc @AlexGhiondea

@ramya-rao-a ramya-rao-a requested a review from nemakam June 28, 2019 01:21
@inech
Copy link
Contributor

inech commented Jul 1, 2019

It's actually a duplicate of #6483

nemakam
nemakam suggested changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@nemakam nemakam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but as suggested by @inech, it's a duplicate of #6483
This PR will be closed.

@nemakam nemakam closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemakam nemakam nemakam requested changes

@axisc axisc axisc approved these changes

@binzywu binzywu Awaiting requested review from binzywu

Assignees
No one assigned
Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@petrformanek @msftclas @azuresdkci @ramya-rao-a @inech @axisc @nemakam