Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for schema create or update for Swagger, WSDL and OpenApi #6038

Merged
merged 2 commits into from
May 2, 2019
Merged

Add support for schema create or update for Swagger, WSDL and OpenApi #6038

merged 2 commits into from
May 2, 2019

Conversation

solankisamir
Copy link
Member

Fix based on REST Spec Azure/azure-rest-api-specs#5824

@solankisamir
Copy link
Member Author

@dsgouda the build failure is related to an EventHub test.

@dsgouda
Copy link
Contributor

dsgouda commented May 2, 2019

@weshaggard Please take a look at the failures.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solankisamir
Copy link
Member Author

@dsgouda I wanted to add an extension to one of the models for better usability. Give me an hour.

@weshaggard
Copy link
Member

@dsgouda I re-queued the failing test leg but I don't believe it is related to the changes in this PR so if it fails again merge anyway.

@jsquire looks like another EventHubs test reliability failure

Failed   Microsoft.Azure.EventHubs.Tests.ServiceFabricProcessor.OptionsTests.RuntimeInformationTest
Error Message:
 Assert.True() Failure
Expected: True
Actual:   False
Stack Trace:
   at Microsoft.Azure.EventHubs.Tests.ServiceFabricProcessor.OptionsTests.RuntimeInformationTest() in D:\a\1\s\sdk\eventhub\Microsoft.Azure.EventHubs\tests\ServiceFabricProcessor\OptionsTests.cs:line 191

I added a note about this test in issue #5995, and if we see it keep failing then I'll disable it.

@solankisamir
Copy link
Member Author

@dsgouda I have pushed my changes. Feel free to merge it as soon as CI passes or fails with EventHub test failure.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solankisamir
Copy link
Member Author

@dsgouda can you merge this.

@dsgouda dsgouda merged commit d8016ae into Azure:master May 2, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
…Azure#6038)

* Add support for schema create or update for Swagger, WSDL and OpenApi

* add wsdl extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants