[Azure Search] .NET SDK v9.0, supporting API version 2019-05-06 #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encryption with customer-managed keys is still in preview.
brjohnstmsft
requested review from
dsgouda,
shahabhijeet,
weshaggard,
Yahnoosh,
ishansrivastava90,
shmed and
arv100kri
arv100kri
approved these changes
Apr 30, 2019
|
@weshaggard someone from data-plane side should review and approve this PR. |
weshaggard
reviewed
Apr 30, 2019
...lane/Microsoft.Azure.Search.Data/Customizations/Documents/Models/IndexBatch.Customization.cs
Show resolved
Hide resolved
|
@AlexGhiondea anyone in particular you would like to review this from data plane prospective? |
weshaggard
reviewed
Apr 30, 2019
src/SDKs/Search/DataPlane/Microsoft.Azure.Search.Common/Microsoft.Azure.Search.Common.csproj
Show resolved
Hide resolved
|
@weshaggard @AlexGhiondea Is any further review required? We'd like to get this merged today so we can publish it to NuGet tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features in this version:
This PR was constructed by copying the changes from the search-preview branch, removing features that are still in preview, regenerating the code with the new 2019-05-06 Swagger spec, and then re-running all tests and re-recording all session records. I recommend reviewing commit-by-commit.
FYI @Yahnoosh @ishansrivastava90 @shmed @arv100kri @updixit @natinimni @dsgouda @shahabhijeet @weshaggard