Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated code and SDK API tests for Personalizer v1.0 preview #5944

Merged
merged 10 commits into from
Apr 29, 2019

Conversation

dwaijam
Copy link
Contributor

@dwaijam dwaijam commented Apr 24, 2019

Add generated code and SDK API tests for Personalizer v1.0 preview
Spec PR links
Azure/azure-rest-api-specs#5743
Azure/azure-rest-api-specs#5777
Both Spec PRs have been merged

@dwaijam dwaijam changed the title Add generated code and SDK API tests for Personalizer v1.0 preview Work in Progress(Need to generate SDK code using azure swagger) - Add generated code and SDK API tests for Personalizer v1.0 preview Apr 24, 2019
@dsgouda
Copy link
Contributor

dsgouda commented Apr 25, 2019

Created for Azure/azure-rest-api-specs#5743

@dwaijam dwaijam changed the title Work in Progress(Need to generate SDK code using azure swagger) - Add generated code and SDK API tests for Personalizer v1.0 preview Add generated code and SDK API tests for Personalizer v1.0 preview Apr 27, 2019
@@ -3,7 +3,7 @@
<PropertyGroup>
<Description>Microsoft.Azure.CognitiveServices.Personalizer.Tests Class Library</Description>
<AssemblyName>Microsoft.Azure.CognitiveServices.Personalizer.Tests</AssemblyName>
<Version>1.0.0</Version>
<Version>0.8.0-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test project version must be set to 1.0.0 and never modified. Not blocking but must be fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once CIs pass

@dsgouda dsgouda merged commit 2778d5d into Azure:master Apr 29, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
…zure#5944)

* Initial setup of Personalizer SDK

* checking in Rank Test

* Add all API tests except evalations

* Consolidate tests to controller groups.

* Add evaluations tests.

* Adding Readme and generate.ps1

* regenerate client and fix tests

* fix all tests , add sdkinfo and metadata files

* fix version names

* add tests proj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants