Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for PolicyInsights #5772

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Conversation

j5lim
Copy link
Contributor

@j5lim j5lim commented Apr 11, 2019

Added a test for policyEvaluationDetails feature.
Updated session records with the correct version.

Related REST spec PRs:
Azure/azure-rest-api-specs#5134
Azure/azure-rest-api-specs#5408

@dsgouda
Copy link
Contributor

dsgouda commented Apr 12, 2019

Verified tests work here

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 672a68c into Azure:master Apr 15, 2019
@j5lim
Copy link
Contributor Author

j5lim commented Apr 15, 2019

@dsgouda Thanks for completing the PR. When will the new PolicyInsight nuget package (version 2.0.2) be released? Is there any process I need to follow to request a release?

@dsgouda
Copy link
Contributor

dsgouda commented Apr 15, 2019

@j5lim Please kick off a publish job using the instructions here in order to publish the Nuget package.

mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
* Add tests for policyEvaluationDetails

* Correct AssemblyVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants