[Service Bus Client] Review and Clean Local Assets (#5354) #5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Service Bus
Client
jsquire
requested review from
AlexGhiondea,
weshaggard,
mikeharder and
kurtzeborn
mikeharder
approved these changes
Mar 13, 2019
src/SDKs/ServiceBus/data-plane/tests/Microsoft.Azure.ServiceBus.Tests/API/APIApprovals.cs
Outdated
Show resolved
Hide resolved
src/SDKs/ServiceBus/data-plane/tests/Microsoft.Azure.ServiceBus.Tests/API/APIApprovals.cs
Outdated
Show resolved
Hide resolved
src/SDKs/ServiceBus/data-plane/tests/Microsoft.Azure.ServiceBus.Tests/API/APIApprovals.cs
Outdated
Show resolved
Hide resolved
weshaggard
reviewed
Mar 13, 2019
jsquire
force-pushed
the
servicebus/loose-asset-tweaks
branch
2 times, most recently
from
ce0d0c0
to
732611b
Compare
Common Repository Structure
- Moving the third party notifications from the Serivce Bus SDK into the root and generalizing.
Service Bus SDK
- Updating the API tests to properly clean up their temporary files on failure.
- Removing the local .gitignore, as there is no longer any content specific to the Service Bus SDK
- Restoring the original content of the ReadMe, which was inadvertently destroyed during a rebase.
- Restoring the deployment template, which was inadvertently destroyed during a rebase.
- Moving local assets from "build" into "assets" to better reflect their identity and avoid the root .gitignore pattern for the directory name [Bb]uild.
- Rename of the deployment template to better reflect its purpose.
- Minor tweaks to ReadMe for asset location updates. [Content remains original. see: Azure#5349]
- Addition of impressions content inito ReadMe.
…client SDK. Discusion has reached consensus that it is not needed.
jsquire
force-pushed
the
servicebus/loose-asset-tweaks
branch
from
732611b
to
1fd79b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this set of changes is intended to tidy some of the local assets associated with the Service Bus client library, which were absorbed when the source code was adopted into the central repository. This scope of this work is intended to be a focused clean-up, with the code and other artifacts otherwise left as they were in the standalone repository, including the existing code formatting and conventions.
Areas for Discussion
UPDATE: per the discussion in the Teams process channel, consensus was reached that the file was not needed. It has been removed from the repository and this pull request.
An authoritative opinion on the
thirdpartynotices.txtfile that has been moved to the repository root would be appreciated. This notice existed within the Service Bus stand-alone repository; I am not sure whether or not it is needed and relevant here or could be safely deleted. It was suggested in a Teams thread that @kurtzeborn and @mikeharder may be good individuals to weigh in on this.Details
Repository Structure
Service Bus Client
Updating the API tests to properly clean up their temporary files on failure.
Removing the local .gitignore, as there is no longer any content specific to the Service Bus library.
Restoring the original content of the local ReadMe, which was inadvertently destroyed during a rebase. (Note: this intentionally leaves the content in a non-compliant state with this repository's norms. That will be addressed in a future set of changes.)
Minor tweaks to the local ReadMe for asset location updates.
Restoring the test infrastructure deployment template, which was inadvertently destroyed during a rebase.
Rename of the deployment template to better reflect its purpose.
Moving local assets from "build" into "assets" to better reflect their identity and avoid the root .gitignore pattern for the directory name
[Bb]uild.Last Upstream Rebase
Wednesday, March 13, 2019 04:43pm(EDT)
Related and Follow-Up Issues