Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Blueprint SDK to use latest swagger (doc updates + RG tagging + lock mode change) #5421

Merged
merged 5 commits into from
Mar 19, 2019

Conversation

stuartko
Copy link
Contributor

@stuartko stuartko commented Mar 12, 2019

A minor update to the Blueprint SDK that adds support for RG tagging (see PR Azure/azure-rest-api-specs#5263 and ResourceGroupDefinition.cs), updates lock mode constants, and takes recent description updates made by our documentation writers.

Copy link
Contributor

@filizt filizt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this from the latest swagger? I can't see the AssignmentLockMode changes.

@filizt
Copy link
Contributor

filizt commented Mar 13, 2019

ChangeNotes for 0.10.0 (breaking changes):

Should we remove these comments? Or add the tags update to it?


Refers to: src/SDKs/Blueprint/Management.Blueprint/Microsoft.Azure.Management.Blueprint.csproj:16 in 51d3d10. [](commit_id = 51d3d10, deletion_comment = False)

@stuartko stuartko changed the title Updating Blueprint SDK to use latest swagger (doc updates + RG tagging) Updating Blueprint SDK to use latest swagger (doc updates + RG tagging + lock mode change) Mar 13, 2019
@stuartko
Copy link
Contributor Author

Is this from the latest swagger? I can't see the AssignmentLockMode changes.

I've now integrated your changes and updated the release notes/version.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate the code using generate.ps1 script and commit all changes generated.

@stuartko
Copy link
Contributor Author

Please generate the code using generate.ps1 script and commit all changes generated.

Done.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Mar 14, 2019

will merge once CIs pass

@dsgouda dsgouda merged commit 94f686f into Azure:master Mar 19, 2019
chidozieononiwu pushed a commit to chidozieononiwu/azure-sdk-for-net that referenced this pull request Mar 26, 2019
…g + lock mode change) (Azure#5421)

* Adding "Tags" property to ResourceGroupDefinition. Taking latest documentation (description) updates

* Bumping version

* Taking another change from the spec repo (lock mode update) and bumping the SDK version

* Bumping version in AssemblyInfo

* Adding changes (metadata) generated via generate.ps1 per request from branch owners
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
…g + lock mode change) (Azure#5421)

* Adding "Tags" property to ResourceGroupDefinition. Taking latest documentation (description) updates

* Bumping version

* Taking another change from the spec repo (lock mode update) and bumping the SDK version

* Bumping version in AssemblyInfo

* Adding changes (metadata) generated via generate.ps1 per request from branch owners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants