Add support and tests for SSL on custom domains in CDN #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we use an existing susbscription that is used for other testing too, the tests failed beacuse they assumed it is a clean subscription. I changed that assumption so that they(hopefully) work with any subscription in record mode.
shahabhijeet
suggested changes
Mar 14, 2019
There was a problem hiding this comment.
You are missing Swagger PR information.
Paste a link to the swagger PR.
Also update nuget package version in .csproj, also update version in AssemblyInfo.cs
Generate SDK using generate.ps1, which will essentially generate all the meta data files that are required for .NET SDK
|
shahabhijeet
suggested changes
Mar 15, 2019
src/SDKs/Cdn/Management.Cdn/Microsoft.Azure.Management.Cdn.csproj
Outdated
Show resolved
Hide resolved
|
@shahabhijeet - can you take a look again at the PR please? |
shahabhijeet
suggested changes
Mar 19, 2019
|
@shahabhijeet - I updated both in the last commit or the commits before. Not sure what I am still missing. |
shahabhijeet
approved these changes
Mar 19, 2019
chidozieononiwu
pushed a commit
to chidozieononiwu/azure-sdk-for-net
that referenced
this pull request
Mar 26, 2019
* Add support and tests for SSL on custom domains in CDN * Fix the test failure for profiles * Fix the build and refactor the profile tests Since we use an existing susbscription that is used for other testing too, the tests failed beacuse they assumed it is a clean subscription. I changed that assumption so that they(hopefully) work with any subscription in record mode. * Update nuget package version * Update file version * Update the moinor version since new functionality was added
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
* Add support and tests for SSL on custom domains in CDN * Fix the test failure for profiles * Fix the build and refactor the profile tests Since we use an existing susbscription that is used for other testing too, the tests failed beacuse they assumed it is a clean subscription. I changed that assumption so that they(hopefully) work with any subscription in record mode. * Update nuget package version * Update file version * Update the moinor version since new functionality was added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to swagger PR - Azure/azure-rest-api-specs#5276