[Storage] Support Failover, and blob Service #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgouda
suggested changes
Nov 14, 2018
| @@ -20,6 +20,7 @@ internal static partial class SdkInfo | |||
| return new Tuple<string, string, string>[] | |||
| { | |||
| new Tuple<string, string, string>("Storage", "BlobContainers", "2018-07-01"), | |||
| new Tuple<string, string, string>("Storage", "BlobServices", "2018-07-01"), | |||
There was a problem hiding this comment.
Please pull down latest changes from remote and run msbuild build.proj and regenerate the code.
There was a problem hiding this comment.
@dsgouda
I have updated the PR per the public swagger, and run msbuild build.proj (Anyway, don't see any change by run msbuild).
Would you please help to review and merge the PR asap?
Thanks!
dsgouda
approved these changes
Nov 16, 2018
| @@ -7,7 +7,7 @@ | |||
| <PackageId>Microsoft.Azure.Management.Storage</PackageId> | |||
| <Description>Microsoft Azure Management Storage Library</Description> | |||
| <AssemblyName>Microsoft.Azure.Management.Storage</AssemblyName> | |||
| <Version>9.0.0-preview</Version> | |||
| <Version>9.1.0-preview</Version> | |||
There was a problem hiding this comment.
@blueww When are you planning to release a stable version? Ideally you should have started preview versioning from 8.8.0-preview and landed on 9.0.0 stable version. Do let us know when you are planning to move to version 10 so we can provide a better idea.
Not blocking on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swagger PR:
The SDK is currently generated from a temp repo with contains all the above swagger PR change.
Will regenerate it against public swagger when all the swagger PR merged.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.