Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated Network SDK based on Swagger's October release #4981

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Generated Network SDK based on Swagger's October release #4981

merged 2 commits into from
Oct 31, 2018

Conversation

anton-evseev
Copy link
Contributor

Description

  • Added operations for ExpressRouteLinks, ExpressRoutePorts, ExpressRoutePortsLocations and LoadBalancerOutboundRules
  • Added support for ApplicationGatewayCustomError and ApplicationGatewayFirewallExclusion
  • Added support for parameters "MaxRequestBodySizeInKb" and "FileUploadLimitInMb" for ApplicationGatewayWebApplicationFirewallConfiguration
  • Added support for "ICMP" value of AzureFirewallNetworkRuleProtocol
  • Added support for parameter "AppliedTo" for EvaluatedNetworkSecurityGroup
  • Added support for parameters "BandwidthInGbps" and "Stag" for ExpressRouteCircuit
  • Added support for "Basic" value of ExpressRouteCircuitSkuTier
  • Added support for parameter "VerbosityLevel" for NetworkConfigurationDiagnostic
  • Renamed NetworkConfigurationDiagnostic's parameter "Queries" to "Profiles" (PR, not sure if it's a breaking change or not)

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@anton-evseev
Copy link
Contributor Author

@MikhailTryakhov @dsgouda please review if assembly version change is correct

 [assembly: AssemblyVersion("19.5.0.0")]
-[assembly: AssemblyFileVersion("19.5.1.0")]
+[assembly: AssemblyFileVersion("19.6.0.0")]

dsgouda
dsgouda suggested changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a minor comment

src/SDKs/Network/Management.Network/Properties/AssemblyInfo.cs
@@ -8,7 +8,7 @@
[assembly: AssemblyDescription("Provides Microsoft Azure Network management functions for managing the Microsoft Azure Network service.")]

[assembly: AssemblyVersion("19.5.0.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set AssemblyVersion to 19.0.0.0
AssemblyFileVersion is correct

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we easily downgrade this version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting myself, please leave AssemblyVersion unchanged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda so can you please merge sdk?

@shahabhijeet shahabhijeet merged commit b5365ba into Azure:psSdkJson6 Oct 31, 2018
@anton-evseev anton-evseev deleted the nrp-october-release branch November 1, 2018 04:52
@anton-evseev anton-evseev mentioned this pull request Nov 27, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda requested changes

@MikhailTryakhov MikhailTryakhov MikhailTryakhov left review comments

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anton-evseev @MikhailTryakhov @dsgouda @shahabhijeet