-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for CertificateInformation and add additional properties to ApiContract #4652
Conversation
@shahabhijeet looks to be some issue with infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great apart from the comment
Start-AutoRestCodeGeneration -ResourceProvider "apimanagement/resource-manager" -AutoRestVersion "latest" -AutoRestCodeGenerationFlags "--tag=package-2018-01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set this tag as the default tag in the REST spec. Is there a reason why you are picking a particular tag here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we want the documentation to be generated off the -preview version, but the SDK to be targeted for specific stable version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC documentation is generated from the published nuget package, so SDK and documentation should ideally be the same version
@shahabhijeet could you please take a look
@solankisamir if your purpose is to generate against selective tag, then that selective tag should be the default tag in your Readme.md. |
@dsgouda updated the SDK generation to be agnostic of version. |
@shahabhijeet @dsgouda a gentle ping on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Apologize for the delay |
Description
Azure/azure-rest-api-specs#3614
Azure/azure-rest-api-specs#3609
Azure/azure-rest-api-specs#3430
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.