Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Text Analytics C# SDK auto-generated code. #4589

Merged
merged 2 commits into from Jul 27, 2018
Merged

Update Text Analytics C# SDK auto-generated code. #4589

merged 2 commits into from Jul 27, 2018

Conversation

yangyuan
Copy link
Member

@yangyuan yangyuan commented Jul 26, 2018 •
edited
Loading

Swagger PR: Azure/azure-rest-api-specs#3491
Doc PR: MicrosoftDocs/azure-docs#12442

Please hold for @assafi's review.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • [x If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@yangyuan yangyuan mentioned this pull request Jul 26, 2018
Merged
dsgouda
dsgouda suggested changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great apart from the minor comment

.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
@@ -6,7 +6,7 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Language.TextAnalytics</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services Language APIs.</Description>
<Version>2.0.0-preview</Version>
<Version>2.1.0-preview</Version>
<AssemblyName>Microsoft.Azure.CognitiveServices.Language.TextAnalytics</AssemblyName>
<PackageTags>Microsoft Cognitive Services;Cognitive Services;Cognitive Services SDK;Text Analytics API;Text Analytics;REST HTTP client;netcore451511</PackageTags>
<PackageReleaseNotes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PackageReleaseNotes here

dsgouda
dsgouda approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Jul 27, 2018

Will merge on CIs passing

@yangyuan
Copy link
Member Author

@dsgouda weird it failed because some package issue. I so rebased to newest psSdkJson6 to see if it works.

@yangyuan
Copy link
Member Author

@dsgouda, it seems to be an issue in Batch:
c:\workspace\VSUpgradeForTest\src\SDKs\Batch\DataPlane\Azure.Batch.Unit.Tests\Azure.Batch.Unit.Tests.csproj : error NU1605: Detected package downgrade: Microsoft.NET.Test.Sdk from 15.0.0 to 15.0.0-preview-20170222-09. Reference the package directly from the project to select a different version.

@dsgouda
Copy link
Contributor

dsgouda commented Jul 27, 2018

@yangyuan kicked off another build. Will investigate if this fails

@yangyuan
Copy link
Member Author

@dsgouda still falls, same error.
Seems that it was cause by the references to different Microsoft.NET.Test.Sdk versions.
Not related to Text Analytics because Text Analytics refer shared AzSdk.test.reference.props

@dsgouda
Copy link
Contributor

dsgouda commented Jul 27, 2018

@yangyuan We are fixing it now

@dsgouda dsgouda merged commit 02cf21e into Azure:psSdkJson6 Jul 27, 2018
@yangyuan yangyuan deleted the yuanyang/endpoint_text_analytics branch February 25, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

@assafi assafi assafi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangyuan @dsgouda @assafi