-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Factory] Adding configure factory repo operation #4360
Conversation
@@ -6,7 +6,7 @@ | |||
<PropertyGroup> | |||
<PackageId>Microsoft.Azure.Management.DataFactory</PackageId> | |||
<Description>Azure Data Factory V2 is the data integration platform that goes beyond Azure Data Factory V1's orchestration and batch-processing of time-series data, with a general purpose app model supporting modern data warehousing patterns and scenarios, lift-and-shift SSIS, and data-driven SaaS applications. Compose and manage reliable and secure data integration workflows at scale. Use native ADF data connectors and Integration Runtimes to move and transform cloud and on-premises data that can be unstructured, semi-structured, and structured with Hadoop, Azure Data Lake, Spark, SQL Server, Cosmos DB and many other data platforms.</Description> | |||
<Version>0.7.0-preview</Version> | |||
<Version>0.8.0-preview</Version> | |||
<AssemblyName>Microsoft.Azure.Management.DataFactory</AssemblyName> | |||
<PackageTags>Microsoft Azure resource management;Data Factory;ADF;</PackageTags> | |||
<PackageReleaseNotes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update PackageReleaseNotes
here or link it to the md file here for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
2) AutoRest information | ||
Requested version: latest | ||
Bootstrapper version: C:\Users\gadongji\AppData\Roaming\npm `-- autorest@2.0.4262 | ||
Bootstrapper version: C:\Users\fgutierr\AppData\Roaming\npm +-- autorest@2.0.4262 `-- oad@0.1.7 `-- autorest@1.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a generate.ps1 script similar to this and regenerate the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@frankycrm14 Thanks for addressing the feedback. One minor thing, please regenerate the code using the generate.ps1 you created and commit all changes |
@@ -1,10 +1,13 @@ | |||
# Changelog for the Azure Data Factory V2 .NET SDK | |||
|
|||
## Current version | |||
## Version 0.8.0-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not add this. I will update the version later when we release. Leave your changes under Current version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@dsgouda I ran the generate.ps1 and changes have been added to PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WIll merge on CIs passing |
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.