Updating Sdk version from preview to non-preview #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgouda
suggested changes
May 21, 2018
| @@ -4,7 +4,7 @@ | |||
| <PackageId>DeviceProvisioningServices.Tests</PackageId> | |||
| <Description>DeviceProvisioningServices.Tests Class Library</Description> | |||
| <AssemblyName>DeviceProvisioningServices.Tests</AssemblyName> | |||
| <VersionPrefix>1.0.1-preview</VersionPrefix> | |||
| <VersionPrefix>1.0.1</VersionPrefix> | |||
There was a problem hiding this comment.
Tests are never published, we recommend simply setting it to 1.0.0 and never change that.
| @@ -8,7 +8,7 @@ | |||
| <Description>Provides management capabilities for Microsoft Azure IoT Device Provisioning Service.</Description> | |||
| <AssemblyTitle>Microsoft Azure Provisioning Service Management</AssemblyTitle> | |||
| <AssemblyName>Microsoft.Azure.Management.DeviceProvisioningServices</AssemblyName> | |||
| <Version>0.9.0-preview</Version> | |||
| <Version>0.9.0</Version> | |||
There was a problem hiding this comment.
If you are planning to release a stable version, we recommend starting versioning from 1.0.0
dsgouda
approved these changes
May 21, 2018
This was referenced Jun 15, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The service has been in GA now.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.