Expose new SKUs for VirtualNetworkGateway ER and VPN VMSS #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose new SKUs for VirtualNetworkGateway ER and VPN VMSS
|
The REST-API PR is Azure/azure-rest-api-specs#3069 |
dsgouda
suggested changes
May 15, 2018
| @@ -7,7 +7,7 @@ | |||
| <PackageId>Microsoft.Azure.Management.Network</PackageId> | |||
| <Description>Provides management capabilities for Network services.</Description> | |||
| <AssemblyName>Microsoft.Azure.Management.Network</AssemblyName> | |||
| <Version>19.0.0-preview</Version> | |||
There was a problem hiding this comment.
This does not look like a breaking change. You can simply set it as 19.0.1-preview instead
There was a problem hiding this comment.
Also, update the PackageReleaseNotes
There was a problem hiding this comment.
Fixed in second commit.
Review Comments
|
Will merge on CIs passing |
dsgouda
reviewed
May 17, 2018
|
|
||
| 1) azure-rest-api-specs repository information | ||
| GitHub user: Azure | ||
| Branch: master | ||
| Commit: b9721ae4c9f04914cc89260b8339dc33372f835b | ||
| Branch: Network-2018-05-01 |
There was a problem hiding this comment.
Apologize for missing this, we cannot accept PRs for sdks generated from a branch other than master. If your changes have already been merged in the Network May REST spec, you don't need this PR
Please talk to @MikhailTryakhov if you have any doubts
|
These changes will be introduced with the Network May REST spec sdk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose new SKUs for VirtualNetworkGateway ER and VPN VMSS
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.