[Azure Search] Merge latest preview changes to psSdkJson6 #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried rebasing the search-4x-preview branch to vs17Dev, but the results were very messy, so instead this is just a squash-merge of all the changes. This should differ from search-4x-preview only in the project files and some minor test changes to account for behavioral changes in the latest version of ClientRuntime.
Search SDK: Upgrading 4x-preview to vs17 and netcore
…ure#3236) * Renaming Management.Search to Microsoft.Azure.Management.Search The package and assembly names were accidentally changed during the VS2017 migration. This fixes it. * Search SDK: Updating Build-SearchPackages script
…ch-preview Merge vs17Dev to search-4x-preview-vs17
…earch-preview [Azure Search] Merge psSdkJson6 to search-4x-preview-vs17 branch
[Azure Search] Merge psSdkJson6 to search-4x-preview-vs17
* SDK Change for SAP ECC (Azure#4063) * add new LinkedService for vertica and netezza, update googleBigQuery (Azure#4070) * add new connector Veritca and Netezza, update Google BigQuery * add new connector Veritca and Netezza, update Google BigQuery * update changelog * resolve conflicts * update changelog * ManagementGroups SDK (Azure#4071) * ManagementGroups SDK * Minor changes * Fixing readme (Azure#4066) * [DataFactory] Updating the SDK version and release notes for 0.5.0 before publishing (Azure#4077) * Updating ADF SDK version for the release * Updating ADF SDK version for the release * Fixing the version for ADF SDK and updating the release notes * Updated the version in csproj and AssemblyInfo * Changed version of Microsoft.Azure.Management.Sql to 1.12.0-preview (Azure#4048) * Adding ZoneBalance and PlatformFaultDomainCount for vm scale set (Azure#4069) * Content moderator update (Azure#4082) * Content moderator update * modified screen text api * Updated the version * Improving reliability of SQL ServerKey tests by adding a short wait between key vault creation and key creation (Azure#4072) * Added more convenient method to rename database (Azure#4056) * Add convenient Database.Rename methods Fixes Azure#4055 * Added test recording * Fixed duplicate release note * Move custom code into customization folder * Skps sdk json6 (Azure#4061) * Added SDK changes for ActionGroup Changes * added change log entry * fixed the Nuget.Config * Commented the unecessary line * Skipped unecessary test * Revrted the version change for Newtonsoft library. * Fixed a comment from SDK team * Update Monitor.Tests.csproj * Changed the Assemblyinfo.cs to change the version. * EventGrid SDK: Removing the preview suffix from the version (Azure#4081) * Regenerated the SDK and re-recorded the tests based on the newer API version. * Re-recorded the tests. * Updated package release notes to reflect this set of changes. * Re-recorded the tests. * Updated the SDK based on the latest data-plane API specifications. * Updated version and release notes. * Update package version to 1.3.0 to remove the preview suffix. * Fixed a typo in the release notes. * Add new features to DataFactory SDK (Azure#4084) * Add new features 1. SecureOutput and BatchCount 2. Filter Activity 3. LInked Service Parameters 4. FilterActivity * Update from running Generate.cmd * Changes corresponding to new swagger PR for API:2018-01-10 (Azure#4075) * Changes corresponding to new swagger PR for API:2018-01-10 * Fixin tests and updating test jsons * Updating nuget version to 2.0.0 * Regenerating changes corresponding to comments on swagger PR. * Updating metadata files as per review comment. * Addressing review comments * Changing customConfig to long and making it a required parameter (Azure#4017) * Regenerating using generate.cmd * Updating minor nuget version for customsearch * Updating link for test framework documentation * Revise notice.txt of Cognitive Services (Azure#4074) * Revise notice.txt Revise notice.txt after PMs confirmed with CELA. * Resolve review comments. Resolve review comments. * .NET SDK and its tests for the 2017-10-12 API version (Azure#4076) * .NET SDK and its tests for the 2017-10-12 API version * Bump the version and generate the meta data file * Updated the version and the metadata * Fixed copyright symbol * Made the AssemblyVersion and AssemblyFileVersion to match the nuget version * [App Insights] Adding Data Plane SDK (Azure#4088) * Adding initial AI Data Plane * Updated generated code & added some metric & event extensions * Added metric extension tests * Tests & fixes for event extensions * Updated AI Data Plane SDK * Minor cleanup to SDK * Fix typing of eventId, rows * Fix tests * Update directory structure; generate.cmd; solution + project files * Fix solution project file * regen from pssdkjson6 * add git commit * adding generated artifacts * updating csproj, adding build artifacts * ServiceBus: properties added to queue and subscription (Azure#4097) * EnableBatchedOperations property added to queue, DeadLetteringOnFilterEvaluationExceptions added to Subscription * bump the minor version * version changed to 1.1.0 * updated resource-manager.txt * [KeyVault] adding readme.md for data-plane (Azure#4100) * creating Azure KeyVault SDK readme for data-plane * readme updates for PR feedback * Update Azure Database Migration Service to add Managed Instance as target (Azure#4098) * Update generated files using specs from latest public preview swagger. * Fix tests. * Changes: - Regenerate models to include commit id. - Update minor version number. * Add generated AzSdk.RP.props * Change version number to 0.2.0 * add dataaction attributes to permissions and Role Definition calls (Azure#4079) * update generated files * update session recs and generated files * fix failing tests * comment extra line * uncomment assemblyinfo file * correct the session recs folder * update session recs file to store and get ids * add metadata files * update csproj and assembleinfo file with newer version * update props file * update package notes * [Azure Search] Upgrade data plane to latest AutoRest and split into 4 packages (Azure#4104) * [Azure Search] Upgrade data plane to the latest version of AutoRest * [Azure Search] Splitting the data plane into four packages What's motivating this change is a recognition that the data plane SDK is really fulfilling three scenarios: 1. Actually implementing search features in applications (full-text search, paging, faceted navigation, etc.) 2. Indexing data via the push API 3. Automating the management of indexes, synonyms, indexers, data sources, and other service-level resources. Scenarios 1 and 2 are what you'd normally think of as "data plane". Scenario 3 is closer to "control plane" or management plane, or even "metadata plane" since managing index schemas in particular is still pretty close to the data. The split goes something like this: - Microsoft.Azure.Search.Data: Fulfills scenarios 1 and 2 above. This covers everything under the /docs resource. Currently most of this is custom code. - Microsoft.Azure.Search.Service: Fulfills scenario 3 above. This covers all top-level resources of the Azure Search Service REST API. This is mostly generated code, and our eventual goal is for nearly all of it to be generated. - Microsoft.Azure.Search.Common: Utilities common to Data and Service. - Microsoft.Azure.Search: A stub package that depends on all the others, plus defines the Indexes.GetClient() method that acts as a bridge from SearchServiceClient to SearchIndexClient. This package provides a convenient upgrade path for existing SDK users. Eventually we're thinking of using Microsoft.Azure.Search.Service in conjunction with Microsoft.Azure.Management.Search to implement a rich set of PowerShell CmdLets that can manage indexes, data sources, indexers, etc. in addition to the ARM-level resources. * [Azure Search] Factoring out data plane assembly and package versions Also bumping all data plane package major versions since moving types to different assemblies is a breaking change. * [Azure Search] Replacing ConverterBase with JsonReader extension methods Reuse via inheritance is an anti-pattern, so we're getting rid of it. * [Azure Search] Fixing issue with copying JsonSerializerSettings Since the Azure .NET SDKs have to support a wide range of JSON.NET versions, it isn't safe to reference properties of JsonSerializerSettings by name since these properties come and go between versions. Instead, we use reflection to dynamically generate code to copy a JsonSerializerSettings instance. * [Azure Search] Versioning each data plane package separately After some discussion, we decided it was better for the purposes of decoupled development and release that we version each of the data plane packages separately.
…ther API obsolete
…ode-functions [Azure Search] Add several indexer features to SDK
[Azure Search] Add service stats API
…ts-api-remove-indexer-limits-sdk Azure Search: remove indexer limits from service stats API
* SDK Change for SAP ECC (Azure#4063) * add new LinkedService for vertica and netezza, update googleBigQuery (Azure#4070) * add new connector Veritca and Netezza, update Google BigQuery * add new connector Veritca and Netezza, update Google BigQuery * update changelog * resolve conflicts * update changelog * ManagementGroups SDK (Azure#4071) * ManagementGroups SDK * Minor changes * Fixing readme (Azure#4066) * [DataFactory] Updating the SDK version and release notes for 0.5.0 before publishing (Azure#4077) * Updating ADF SDK version for the release * Updating ADF SDK version for the release * Fixing the version for ADF SDK and updating the release notes * Updated the version in csproj and AssemblyInfo * Changed version of Microsoft.Azure.Management.Sql to 1.12.0-preview (Azure#4048) * Adding ZoneBalance and PlatformFaultDomainCount for vm scale set (Azure#4069) * Content moderator update (Azure#4082) * Content moderator update * modified screen text api * Updated the version * Improving reliability of SQL ServerKey tests by adding a short wait between key vault creation and key creation (Azure#4072) * Added more convenient method to rename database (Azure#4056) * Add convenient Database.Rename methods Fixes Azure#4055 * Added test recording * Fixed duplicate release note * Move custom code into customization folder * Skps sdk json6 (Azure#4061) * Added SDK changes for ActionGroup Changes * added change log entry * fixed the Nuget.Config * Commented the unecessary line * Skipped unecessary test * Revrted the version change for Newtonsoft library. * Fixed a comment from SDK team * Update Monitor.Tests.csproj * Changed the Assemblyinfo.cs to change the version. * EventGrid SDK: Removing the preview suffix from the version (Azure#4081) * Regenerated the SDK and re-recorded the tests based on the newer API version. * Re-recorded the tests. * Updated package release notes to reflect this set of changes. * Re-recorded the tests. * Updated the SDK based on the latest data-plane API specifications. * Updated version and release notes. * Update package version to 1.3.0 to remove the preview suffix. * Fixed a typo in the release notes. * Add new features to DataFactory SDK (Azure#4084) * Add new features 1. SecureOutput and BatchCount 2. Filter Activity 3. LInked Service Parameters 4. FilterActivity * Update from running Generate.cmd * Changes corresponding to new swagger PR for API:2018-01-10 (Azure#4075) * Changes corresponding to new swagger PR for API:2018-01-10 * Fixin tests and updating test jsons * Updating nuget version to 2.0.0 * Regenerating changes corresponding to comments on swagger PR. * Updating metadata files as per review comment. * Addressing review comments * Changing customConfig to long and making it a required parameter (Azure#4017) * Regenerating using generate.cmd * Updating minor nuget version for customsearch * Updating link for test framework documentation * Revise notice.txt of Cognitive Services (Azure#4074) * Revise notice.txt Revise notice.txt after PMs confirmed with CELA. * Resolve review comments. Resolve review comments. * .NET SDK and its tests for the 2017-10-12 API version (Azure#4076) * .NET SDK and its tests for the 2017-10-12 API version * Bump the version and generate the meta data file * Updated the version and the metadata * Fixed copyright symbol * Made the AssemblyVersion and AssemblyFileVersion to match the nuget version * [App Insights] Adding Data Plane SDK (Azure#4088) * Adding initial AI Data Plane * Updated generated code & added some metric & event extensions * Added metric extension tests * Tests & fixes for event extensions * Updated AI Data Plane SDK * Minor cleanup to SDK * Fix typing of eventId, rows * Fix tests * Update directory structure; generate.cmd; solution + project files * Fix solution project file * regen from pssdkjson6 * add git commit * adding generated artifacts * updating csproj, adding build artifacts * ServiceBus: properties added to queue and subscription (Azure#4097) * EnableBatchedOperations property added to queue, DeadLetteringOnFilterEvaluationExceptions added to Subscription * bump the minor version * version changed to 1.1.0 * updated resource-manager.txt * [KeyVault] adding readme.md for data-plane (Azure#4100) * creating Azure KeyVault SDK readme for data-plane * readme updates for PR feedback * Update recommendation engine APIs and their test * Generating SDK based on 2018-03-01-preview version. * Generate sdk from swagger, add new test for cancel pool operation and list database/pool operation * Update Azure Database Migration Service to add Managed Instance as target (Azure#4098) * Update generated files using specs from latest public preview swagger. * Fix tests. * Changes: - Regenerate models to include commit id. - Update minor version number. * Add generated AzSdk.RP.props * Change version number to 0.2.0 * Deleting old session records. * Adding zone scenario tests for Private DNS. * Modifying RecordSet tests for Private zones. * Including session records again. * Bumping up the version. * Re-generating the SDK based from generate.cmd (fork: owolabi2/private-dns-public-preview). * Update recommendation engine APIs and their test * Fix assembly version and VersionPrefix, add .props file * add dataaction attributes to permissions and Role Definition calls (Azure#4079) * update generated files * update session recs and generated files * fix failing tests * comment extra line * uncomment assemblyinfo file * correct the session recs folder * update session recs file to store and get ids * add metadata files * update csproj and assembleinfo file with newer version * update props file * update package notes * Fix versions in .csproj files * [Azure Search] Upgrade data plane to latest AutoRest and split into 4 packages (Azure#4104) * [Azure Search] Upgrade data plane to the latest version of AutoRest * [Azure Search] Splitting the data plane into four packages What's motivating this change is a recognition that the data plane SDK is really fulfilling three scenarios: 1. Actually implementing search features in applications (full-text search, paging, faceted navigation, etc.) 2. Indexing data via the push API 3. Automating the management of indexes, synonyms, indexers, data sources, and other service-level resources. Scenarios 1 and 2 are what you'd normally think of as "data plane". Scenario 3 is closer to "control plane" or management plane, or even "metadata plane" since managing index schemas in particular is still pretty close to the data. The split goes something like this: - Microsoft.Azure.Search.Data: Fulfills scenarios 1 and 2 above. This covers everything under the /docs resource. Currently most of this is custom code. - Microsoft.Azure.Search.Service: Fulfills scenario 3 above. This covers all top-level resources of the Azure Search Service REST API. This is mostly generated code, and our eventual goal is for nearly all of it to be generated. - Microsoft.Azure.Search.Common: Utilities common to Data and Service. - Microsoft.Azure.Search: A stub package that depends on all the others, plus defines the Indexes.GetClient() method that acts as a bridge from SearchServiceClient to SearchIndexClient. This package provides a convenient upgrade path for existing SDK users. Eventually we're thinking of using Microsoft.Azure.Search.Service in conjunction with Microsoft.Azure.Management.Search to implement a rich set of PowerShell CmdLets that can manage indexes, data sources, indexers, etc. in addition to the ARM-level resources. * [Azure Search] Factoring out data plane assembly and package versions Also bumping all data plane package major versions since moving types to different assemblies is a breaking change. * [Azure Search] Replacing ConverterBase with JsonReader extension methods Reuse via inheritance is an anti-pattern, so we're getting rid of it. * [Azure Search] Fixing issue with copying JsonSerializerSettings Since the Azure .NET SDKs have to support a wide range of JSON.NET versions, it isn't safe to reference properties of JsonSerializerSettings by name since these properties come and go between versions. Instead, we use reflection to dynamically generate code to copy a JsonSerializerSettings instance. * [Azure Search] Versioning each data plane package separately After some discussion, we decided it was better for the purposes of decoupled development and release that we version each of the data plane packages separately. * Add web_resource-manager.txt * "automation" was misspelled (Azure#4107) * Bumping up the version again to 2.2.0 since 2.1.0 will be used by 2017-10-01 API version. * Update AzureApiTag to AzSdk.RP.props and add SdkInfo_WebSiteManagementClient.cs * Re-generating the SDK making the ZoneType optional. * [Monitor] SDK version 0.19.0-preview (Azure#4108) * [Monitor] SDK version 0.19.0-preview * [Monitor] SDK version 0.19.0-preview * [Monitor] SDK version 0.19.0-preview * [Monitor] SDK version 0.19.0-preview * [Monitor] SDK version 0.19.0-preview * [Monitor] SDK version 0.19.0-preview * initial commit - need to fix usage test case initial commit - need to fix usage test case * Add first version of .NET SDK for Policy Insights RP (Azure#4117) * Add SDK for PolicyInsights with initial set of tests (incomplete) * Rest of the scope tests * Minor changes * Add query option tests * Add policy insights to documentation files * Changes requested as part of PR * Fix generate.cmd * Run generate to generate metadata * Change version as suggested * Remove hardcoded paths * Add subscription ID to recorded session data instead of setting it in code * Remove commented out code * [Apim] Autorest based .NET client on 2018-01-01 version with Tests (Azure#4115) * 2018-01-01 client and basic tests * Updated tests and generated expected metadata artifacts * Fix ApiRevisionId and other test fixes * Extension fixes * update roledefinition filters (Azure#4102) * update tests to include type filter for roledefinitions * update version * rerecord tests * Update DNS SDK for 2017-10-01 API Version (Azure#4118) * Update Azure DNS SDK for 2017-10-01 API Version * Update test recordings for DNS SDK 2017-10-01 API Version * Update 2017-10-01 DNS API version Swagger based on code review feedback * Re-generate DNS SDK from 2017-10-01 official swagger * Add AzSdk.RP.props for DNS SDK * Including changes for 2017-10-01 API version. * Re-recording all tests. * Minor refactoring. * Fixing duplicated lines. * Regenerate to correct limit/currentValue types Regenerate with the latest swagger to correct limit/currentValue types. Now Usage UT can pass. * Bump version to 4.0.0.0 Bump version to 4.0.0.0 * Update RecordSession for CognitiveServicesAccountUpdateWithCreateTest Update RecordSession for CognitiveServicesAccountUpdateWithCreateTest * Generating SDK against merged Swagger. * capitalizing DNS in csproj * Downgrading assemblyversion to 2.1.0.0 * * Add AzureDatabricks LinkedService and DatabricksNotebook Activity * Add headNodeSize and dataNodeSize properties in HDInsightOnDemand LinkedService. * Add LinkedService, Dataset, CopySource for SalesforceMarketingCloud * Generating DNS client from latest Swagger changes * Updating DiskRP API version to 2018-04-01 and adding zone resilient property to image storage profile (Azure#4129) * Sync the SDK repo with original. Sync official rest-api-specs with checked-in changes and renenerate the SDK * Introducing generate.ps1 to replace generate.cmd (Azure#4123) * Adding generate.ps1 * better logging, hooks for generate.cmd * Addressing comments * Addressing PR comments * [Monitor] Fixing bug Azure#2655: the top argument of the Metrics API must be a integer instead of a double * Fixing remove-module error (Azure#4133) * Update Auditing & ThreatDetection tests. (Azure#4127) Re-recorded tests with updated expecations due to minor changes in service behavior. * generate the .net sdk from official swagger repo azure/azure-rest-api-specs. Bump the api version in Assembly file and csproj * regenerate the sdk since the swagger is updated * [Monitor] Adding metadata file to PR * Update ElasticPool test, only sleep when in Record mode * do a git clean on working branch, rerun generate.cmd * delete the release note for sdk version 1.12.0-preview * logging invoker information to file (Azure#4137) * fix build issue in ElasticPoolCrudScenarioTests.cs * Add missing test for vmss redeploy and perform maintenance. (Azure#4135) * Updating ADF SDK version and release notes before publishing (Azure#4138) * Update changelog.md Updating the change log for release * Update Microsoft.Azure.Management.DataFactory.csproj Updating proj file with release notes * Determining sdkdirectory for powershell invokers * Regen from swagger * LTR tests * Adding tests that are actually recordable. * Updating version info * Ran msbuild build.proj /t:Build /p:Scope=SDKs\SqlManagement per request. * Bump up managementpartner sdk version and change the package release notes * Undo version changes and add release notes for the newly added APIs and the breaking changes * [Monitor] Unblocking the publication of the SDK (Azure#4141) * Address comments pertaining to tests * Adding tests for all LRO Rules agreed upon with ARM team. (Azure#4142) * Adding tests for all LRO Rules agreed upon with ARM team. Accomodating 404, 204 for delete on Final GET. Accomodating text/plain content type certain RP still sending under pretext of application/json * Updating E2E Scenario test * Move Bing Search SDKs from Preview to GA * Updating ClientRuntime release notes as well as version (Azure#4145) * Regen from master Regenerated from master, only the sql_resource-manager.txt is changed. * rerun generate.cmd to generate sdk * Add generate.ps1 script and run it * remove sdkDirectory argument in generate.ps1 script * Fixing compute script and error handling fixes * Address Comments * Adding instructions to generate code * instructions to generate code from custom repo * 1. Re-generate SDK 2. Update existing session records to reflect updated api-version * reverting generate.cmd to old behavior * Update SDK and test for BatchAI for GA * Add enrollment account tests. * Rev version. * 1. update SDK version 2. add PS generate script * Fix versions. * Add generate.ps1 * update release note for GA BatchAI SDKs * WebSites ResourceHealthMetadata APIs and Tests Adding the Microsoft.Web ResourceHealthMetadata APIs as well as new test cases for these APIs * Updating WebSites SDK versions Updating WebSites SDK versions * Minor test naming fixes. * Re-generate using generate.ps1. * Update Azure Batch .Net SDK to meet API version 2018-03-01.6.1. (Azure#4151) * Regenerate protocol based on 2018-02 Swagger spec * Add object model layer for new APIs * Update MSBuild version for ProxyLayerParser * Add tests for new APIs * Update Batch version to 8.1.0 - Updated the changelog as well. * Update to latest swagger spec. * Add AzSdk.RP.props to source. * Move LogUpload test case to IaaS pool. * Add Custom Vision Training and Prediction projects Add session recordings for tests * Update version * Update versions + generation scripts * ReRecord failed test due to CR upgrade. (Azure#4159) * RPs whose tests have to be re recorded after CR update across the repo. Adding missing meta data files. Updating few test projects that have not been authored correctly * ReRecording ApiManagement tests due to ClientRuntime update * ApiMgmt, BatchMgmt and cdn rerecorded tests for CR update * ReRecording Compute, Dns, MLCompute, RecSvcSiteRecovery, Sql, StreamAnalytics * ReRecording DataFactory, EventHub, NotificaitonHub, Relay, StorSimple and TrafficManager tests due to CR change * ReRecording ContainerRegistry, DataMigration, HDInsights, KeyVault, PowerBIDedicated, RedisCache, Resource, ServiceBus tests for CR Update * ReRecording Customer Insights, EventGrid, MachineLearning test due to CR update. * Fixing improper merge * ReRecording Fabric.Admin tests due to CR update * Fixing encoding so github can see diffs * Update BatchAI test record * Re-recording tests and fixes * subscription-2018-03-01-preview (Azure#4157) * subscription-2018-03-01-preview * ran generate.ps1 * minor fixes * reran tests * added package release notes and bumped version * pulled upstream changes, reran generate.ps1 * fix csproj * fixed props * Update package information (Azure#4163) * restore point create and delete API missed test added (Azure#4168) * ServiceBus: 'properties' added to Rules CorrelationFilter (Azure#4167) * Added 'properties' in correlation filter * updated session records * code generated using generate.ps1 * adding license header to gen tool (Azure#4173) * adding license header to gen tool * Update generateTool.ps1 * Update sdk with latest swagger spec. * Update generated data * Bump version * Update tests * fixing xml comment on KeyWrapAlgorithm.CreateDecryptor * .Net SDK for PostgreSQL. (Azure#4175) * .Net SDK for PostgreSQL.. * Update test recordings. * Resolve PR comments. * Update props file and add metadata * Update test recordings. * Handle PR feedback. * Update release notes * Update .props file * Update .props file * Fix .props file * Generate again with hotfix changes * Add generate.ps1 * Regenerate with generate.ps1 * Update props file * Regenerated Commerce Admin * Updated version and generate script * Added generate.ps1, regenerated, including some text file
[Azure Search] Replacing generate.cmd with generate.ps1 and regenerat…
Changes include: - Removing some obsolete indexer configuration methods - Adding some new indexer configuration methods - Adding new indexer field mapping functions - Adding indexer warnings - Adding new Service Stats API - Replacing every generate.cmd with generate.ps1
|
I reviewed this commit, LGTM. |
natinimni
approved these changes
Apr 10, 2018
shahabhijeet
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes include:
Related Swagger PRs:
Note that we are not updating the version number because version 5.0-preview has not shipped yet (i.e. -- I bumped the version number before making these changes).
Also note that we're not squashing commits since we're merging from a long-term branch and want to preserve history.
FYI @mhko @natinimni @chaosrealm
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.