Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sdk for ACE provisioning GSM, the sdk can be used to do partner management #4019

Merged
merged 8 commits into from
Jan 31, 2018
Merged

Conversation

jeffrey-ACE-zz
Copy link
Contributor

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does GSM mean? What is the name of your service, why use acronym.
Please do the following in order

  1. Generate your SDK using generate.cmd
  2. build your project as below
    msbuild build.proj /t:build /p:Scope=SDKs\Gsm

Following above steps will add meta data files.

Please also provide links to merged spec repo PRs

<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<Folder Include="Properties\" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove, no need to add this directory explicitly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet GSM stands for Global subscription management, it is also our web role name.
Thanks for reviewing the code, fix the comments.
This is our spec repo pr: Azure/azure-rest-api-specs#2285

<!-- Please do not move/edit code below this line -->

<PropertyGroup>
<PackageId>Microsoft.Azure.Management.Gsm</PackageId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation.

@jeffrey-ACE-zz
Copy link
Contributor Author

@shahabhijeet after talking to my manager and PM, we decide to rename the namespace to managementPartner. Can you please continue the review?

@jeffrey-ACE-zz
Copy link
Contributor Author

@shahabhijeet thank you so much for your help at Friday. My pr for swagger folder renaming is merged: Azure/azure-rest-api-specs#2351. So regenerated the SDK and updated the PR, can you please take a look?

@shahabhijeet shahabhijeet merged commit 78d41b4 into Azure:psSdkJson6 Jan 31, 2018
@jeffrey-ACE-zz
Copy link
Contributor Author

@shahabhijeet thank you so much. Can I know when will the package be published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants