-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new sdk for ACE provisioning GSM, the sdk can be used to do partner management #4019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does GSM mean? What is the name of your service, why use acronym.
Please do the following in order
- Generate your SDK using generate.cmd
- build your project as below
msbuild build.proj /t:build /p:Scope=SDKs\Gsm
Following above steps will add meta data files.
Please also provide links to merged spec repo PRs
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
<Folder Include="Properties\" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove, no need to add this directory explicitly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahabhijeet GSM stands for Global subscription management, it is also our web role name.
Thanks for reviewing the code, fix the comments.
This is our spec repo pr: Azure/azure-rest-api-specs#2285
<!-- Please do not move/edit code below this line --> | ||
|
||
<PropertyGroup> | ||
<PackageId>Microsoft.Azure.Management.Gsm</PackageId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation.
@shahabhijeet after talking to my manager and PM, we decide to rename the namespace to managementPartner. Can you please continue the review? |
@shahabhijeet thank you so much for your help at Friday. My pr for swagger folder renaming is merged: Azure/azure-rest-api-specs#2351. So regenerated the SDK and updated the PR, can you please take a look? |
@shahabhijeet thank you so much. Can I know when will the package be published |
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.