Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding WriteAcceleratorEnabled property for Disks, and adding Compute… #4013

Closed
wants to merge 4 commits into from
Closed

adding WriteAcceleratorEnabled property for Disks, and adding Compute… #4013

wants to merge 4 commits into from

Conversation

hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Jan 24, 2018 •
edited
Loading

…rName, OsName and OsVersion properties for VM instance view.

Azure/azure-rest-api-specs#2294

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@hyonholee
adding WriteAcceleratorEnabled property for Disks, and adding Compute…
8f6d09b 
…rName, OsName and OsVersion properties for VM instance view.
shahabhijeet
shahabhijeet suggested changes Jan 24, 2018
View reviewed changes
Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anytime API version changes, it has to be updated in the meta data file.
Please build at least once in command line to get the updated meta data file.

shahabhijeet
shahabhijeet suggested changes Jan 31, 2018
View reviewed changes
Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API change requires you to at least build your generated SDK from command line, so that it updates the meta data.

@hyonholee
adding WriteAcceleratorEnabled property for Disks, and adding Compute…
f524585 
…rName, OsName and OsVersion properties for VM instance view.
@hyonholee
Merge branch 'writeaccel' of https://github.com/hyonholee/azure-sdk-f…
ba61181 
…or-net into writeaccel

# Conflicts:
#	src/SDKs/_metadata/compute_resource-manager.txt
@hyonholee
Copy link
Contributor Author

#4029

@hyonholee hyonholee closed this Feb 2, 2018
@hyonholee hyonholee deleted the writeaccel branch February 2, 2018 22:09
This was referenced Nov 30, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyonholee @shahabhijeet