[Azure Search] Upgrade Management SDK to version 2.0 #3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stock generate.cmd script takes way too many parameters to be useful when iterating on a private Swagger spec.
Also re-recording all session records.
Added new generated code, plus a scenario test and corresponding session record.
A major version bump is necessary because the behavior of Services.CreateOrUpdate has changed. Specifically, service creation and scaling is now synchronous instead of asynchronous. Also, there is new API surface area that represents breaking changes from the .NET point of view (i.e. -- new methods added to existing interfaces).
Since the refactor, the default branch is master, not current.
This includes some minor doc changes.
shahabhijeet
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings the version of the Azure Search management SDK from 1.0.2 to 2.0.0. Changes include:
OperationsAPI is now exposed through the SDK.Services.CreateOrUpdateis now synchronous. The operation will not return until service provisioning has completed. Whereas before users of the SDK had to write code to poll the provisioning state, now the SDK does this polling automatically.Services.BeginCreateOrUpdatehas been introduced for scenarios where users still want to do the aforementioned polling themselves.Some of these are breaking changes, hence the major version bump.
I recommend reviewing each commit separately.
Note: I am fixing an oversight in the global generate.cmd as part of this PR. It will now target the
masterbranch of azure-rest-api-specs by default instead of the oldcurrentbranch.Swagger PR: Azure/azure-rest-api-specs#2242
FYI @Yahnoosh @natinimni @mhko @chaosrealm @shahabhijeet
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.