Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Updating System.Diagnostics.DiagnosticSource types usage #37661

Merged
merged 4 commits into from
Jul 19, 2023
Merged

[Core] Updating System.Diagnostics.DiagnosticSource types usage #37661

merged 4 commits into from
Jul 19, 2023

Conversation

m-redding
Copy link
Member

@m-redding m-redding commented Jul 17, 2023 •
edited
Loading

Contributes to #37593

This pull request updates the types used from System.Diagnostics.DiagnosticSource in order to remove as much of the ActivityExtensions class as possible. Right now, ActivitySource is still considered experimental. Because of this, it's easiest to leave the two methods in the ActivityExtensions class to keep track of if ActivitySource is enabled. Once ActivitySource is no longer considered experimental, then we can remove this class entirely.

In addition, rather than deleting the previously used code, it is wrapped in preprocessor directives to keep the NETCOREAPP2.1 build target from breaking. Once the NETCOREAPP2.1 target is removed, then all of this code can be removed.

This work was prepped by the following PRs:

Additional Information and context is here:

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@m-redding m-redding marked this pull request as ready for review July 17, 2023 22:55
@lmolkova
Copy link
Member

/cc @sourabh1007 JFYI

lmolkova
lmolkova approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAAAYY

@m-redding m-redding merged commit c3b7682 into Azure:main Jul 19, 2023
55 checks passed
@m-redding m-redding deleted the upgrading-core branch July 19, 2023 21:18
This was referenced Jul 20, 2023
Closed
Closed
bharat-kalyan-namburi pushed a commit that referenced this pull request Aug 7, 2023
@vivekmore-msft @jsquire
@christothes @rajkumar-rangaraj @reutgross @azure-sdk @sarkar-rajarshi @ShivangiReja @TimothyMothra @williamzhao87 @vishweshbankwar @aleksriabov @live1206 @fangchen0601 @raych1 @RichardAtMoverDk @JoshLove-msft @kinelski @JimSuplizio @Vibhuti-Sharma-Microsoft @amatukmolina @m-redding @mikeharder @ArthurMa1978 @mcgallan @heaths @minghan @WeihanLi @amnguye @ambrahma @dvbb @ArcturusZhang @drwill-ms @jaschrep-msft @juntuchen-msft @trrwilson @danieljurek @msJinLei @xirzec @archerzz @lemonicetea @seanmcc-msft @yifanz7 @RodgeFu @EldertGrootenboer @scottaddie @huachuandeng @ctyar @Harshit-Shrivastava @benbp @pshao25 @KrzysztofCwalina @sofiar-msft @scbedd @solankisamir @haagha @minnieliu @vidit-msft @SrinikhilReddy @carjackson-msft @himanshudhawale @minwoolee-msft @billwert @calvinkwtang @priyamshet @Mohana-Krishna-Nali @Joanna-Yang-Art @hakimms @elanmart @wsugarman @Juliehzl @atazimsft @abhishesingh-msft
Fixed build issues (#38046)
204617c 
* CODEOWNERS: Fix OpenAI PR Label (#37558)

Fixing the label applied for OpenAI pull requests.

* Azure Core API feedback (#37557)

* [AzureMonitorExporter] Add support new Messaging semantics - Request/Dependency Telemetry (#37508)

* PR feedback  + tests.

* [AzureMonitorExporter] Add support new Messaging semantics - Request / Dependency Telemetry

* Fix test

* New changes

* nits

* Remove unused method.

* Fix message sematics to support Azure SDK.

* Self-review fix

* Fix build + Test Fix

* readme (#37556)

* Increment version for core releases (#37559)

* Increment package version after release of Azure.Core.Experimental

* Increment package version after release of Azure.Core

* update autorest to point to new swagger specs (#37565)

- make UnassignJobRequest internal

* [ACR] Upgrade Azure.Core dependency (#37561)

* [ACR] Fix Azure.Core package dependency

* Increment package version after release of Azure.Containers.ContainerRegistry (#37569)

* prepare AzureMonitorExporter and AzureMonitorDistro for release (#37503)

* run prepare-release script

* remove newline

* update timestamp

* update distro for Azure Activity Sources

* move section

* Update CHANGELOG.md

* [JobRouter] Use internal setters (#37570)

* Set ai.user.useragent to userAgentOriginal (#37571)

* Set ai.user.useragent to userAgentOriginal

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Customizations/Models/TelemetryItem.cs

Co-authored-by: Timothy Mothra <tilee@microsoft.com>

* fix build

---------

Co-authored-by: Timothy Mothra <tilee@microsoft.com>

* [ACS JobRouter] Missing usage of Azure.Etag in RouterQueueItem (#37573)

* missing usage of Azure.Etag in RouterQueueItem

* remove empty classes

* remove setter of ScheduleAndSuspendMode from JobMatchingMode

* Fix code generation for EmailAttachment serialization (#37524)

* Add directive to use Content for contentInBase64 property

* Update link to specification file

* Remove obsolete ContentInBase64 property

* Bump version of subscription (#36355)

* test

* update

* remove date from tag

* Update api version of subscriptin for tests

* Revert "Update api version of subscriptin for tests"

This reverts commit dbbafd1.

* update

* Remove api-version of tenant for test

* remove api-version

* prepare release

* Increment version for maps releases (#37575)

* Increment package version after release of Azure.Maps.Geolocation

* Increment package version after release of Azure.Maps.Routing

* Increment package version after release of Azure.Maps.Common

* Increment package version after release of Azure.Maps.Rendering

* Increment package version after release of Azure.Maps.Search

* [Azure Communication Services][CallAutomation]Create Customcontext class (#37548)

* create Customcontext class

* fix UT

* update api

* for groupcall, create both headers by default

* fix comments

* update api

* Updated automation script used in docker scenario (#37447)

* Updated automation script used in docker scenario

* Pass in spec root dir to dotnet build

* Revert analyzer version change

* Ignore removing specification for pipeline scenario

* Fix typo 'Comsmos' to 'Cosmos' (#37588)

The namespace `Microsoft.Azure.Cosmos.Table` has been erroneously copied around as `Microsoft.Azure.Comsmos.Table`.

* Increment version for webpubsub releases (#37580)

* Increment package version after release of Microsoft.Azure.WebJobs.Extensions.WebPubSub

* Increment package version after release of Microsoft.Azure.WebPubSub.AspNetCore

* Increment package version after release of Azure.ResourceManager (#37576)

* [Event Hubs] Migration Guide Tweaks (#37591)

The focus of these changes is to update the client hierarchy and status
of the legacy packages, while tuning some of the phrasing of the migration guide.

* Use property reference type (#37542)

* Use property reference type

* docs

* Add ctor attributes

* Make discriminator property public

* remove attribute args

* Try referenceType

* Revert attribute changes and add model factory

* Add ref docs

* [MetricsAdvisor] Removed AZC0007 NoWarn option (#37595)

* Increment package version after release of Azure.Core.Expressions.DataFactory (#37599)

* Fix standard metric for updated semantic conv (#37603)

* Update version of github-event-processor (#37602)

Co-authored-by: James Suplizio <jasupliz@microsoft.com>

* update readme to include Azure SDK support (#37606)

* update readme to include Azure SDK support

* changelog

* fix md error

* Generated sdk from updated spec - Ngfw (#36881)

* Microsoft.GraphServices add new SDK version for stable swagger spec (#37105)

* Add new SDK generation for stable swagger spec

* Run dotnet build /t:GenerateTests

* Change project settings and re-record session

* Remove duplicate packages

* Upload run to assets repo

* regenerate code and rerun tests

* Rerun tests and upload to assets repo

* address comments

* change version in changelog

* readd beta version in changelog

* Remove unreleased tag from changelog

* Add date to 1.0.0 version

* remove empty sections

* polish

---------

Co-authored-by: Wei Hu (from Dev Box) <huwe@microsoft.com>

* Increment version for monitor releases (#37613)

* Increment package version after release of Azure.Monitor.OpenTelemetry.Exporter

* Increment package version after release of Azure.Monitor.OpenTelemetry.AspNetCore

* Update AutoRest C# version to 3.0.0-beta.20230713.1 (#37612)

* Update Generator Version 3.0.0-beta.20230713.1

* Update SDK codes

* Update Generator Version 3.0.0-beta.20230714.1 (#37617)

* DefaultAzureCredentialOptions.TenantId now overrides the environment when selecting EnvironmentCredential (#37537)

* update MSAL dependencies (#37589)

* Update readme file link to documentation  (#37583)

* readme

* readme

* readme

* readme

* Increment package version after release of Azure.ResourceManager.PaloAltoNetworks.Ngfw (#37610)

* Add IsSupportLoggingEnabled property to TokenCredentialOptions (#37463)

* [Event Hubs] Upgrade management package (#37568)

* [Event Hubs] Upgrade management package

The focus of these changes is to update the management package used by
test infrastructure to manage ephemeral resources for test isolation.
The current generation management package has reached GA and the legacy
package is now deprecated.

* Removing unused Polly reference in Processor.Perf

* Fixing order of references to be alphabetical

* Fixing Experimental references and applying minor PR feedback

* Removing property that will be obsolete in the future but is not in the current package to appease CI

* Enable MSA Passthrough for WAM (#37567)

* Fix DataFactory README and bump central version (#37624)

* Fix DataFactory README and bump central version

* fix spacing

* moving off activity extensions (#37597)

* Update AutoRest C# version to 3.0.0-beta.20230714.2 (#37626)

* Update Generator Version 3.0.0-beta.20230714.2

* Update SDK codes

* Update SDK codes

* Regen DF api

* Apply config to synapse

---------

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

* Sync eng/common directory with azure-sdk-tools for PR 6521 (#37627)

* Use System.Threading.Mutex to make threadsafe

* Rename test, add comments

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>

* Ignore api-version for mgmt tests (#37582)

* Update Generator Version 3.0.0-beta.20230714.3 (#37636)

Co-authored-by: Arthur Ma <arthurma@microsoft.com>

* Remove workaround for final-state-schema (#37641)

* Update Generator Version 3.0.0-beta.20230717.1 (#37647)

* Health bot tests (#35979)

* Analysis tests (#37065)

* Disable deprecated track 1 SDKs from building (#37655)

These are generating CG alerts unnecessary and are both deprecated in
favor of Azure Monitor Query SDK.

* Add missing service label entries to CODEOWNERS (#37638)

* Update Microsoft.Rest.ClientRuntime (#37654)

* Update Microsoft.Rest.ClientRuntime

Updates a couple perf projects to use the newest
Microsoft.Rest.ClientRuntime for CVE-2022-26907.

* Fix xUnit2000 test warning-as-error

* Disable PR pipelines for deprecated packages

* Update StorageRequestFailedDetailsParser to handle inexact type (#37648)

* Update StorageRequestFailedDetailsParser.cs

* Update StorageRequestFailedDetailsParser.cs

* update release dates (#37658)

* [Event Grid] [Event Hubs] [Service Bus] [Storage] Adding ActivitySource and migrating all DiagnosticScope.ActivityKind references (#37600)

* migrating to system diagnostics

* fixing method signature and fixing storage test

* pipeline fix

* fixing pipeline 2

* Update Microsoft.Azure.WebJobs.Extensions.ServiceBus.csproj

* update dependency

* fix

* [FormRecognizer] Updated tests after recent service deployment (#37618)

* fix Azure.Core reference (#37659)

* AsyncAutoResetEvent enhancement (#35593)

- Use Task.CompltedTask
- Let class sealed

* [JobRouter] Fix TTL (#37662)

* [Storage] [DataMovement] Made the respective members `public` to `protected internal` members (#37604)

* Changed all valid members of the StorageResource class to either protected or protected internal

* Updated Changelog

* PR comments

* Increment version for identity releases (#37664)

* PostgreSQL Flexible server added support for new api version 2023-03-01-preview which includes some new features and bug fixes (#36788)

Co-authored-by: Chengming <v-cruan@microsoft.com>
Co-authored-by: Wei Hu <huwe@microsoft.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>

* Skip ApiCompat for SDK automation (#37688)

* Increment package version after release of Azure.ResourceManager.PostgreSql (#37690)

* Remove myself as a codeowner (#37656)

* [CODEOWNERS] Fix Operational Insights label (#37693)

The focus of these changes is to update the CODEOWNERS registration to match the expected label.

* Remove deprecated StorSimple 8000 series SDK (#37678)

Relates to #37660

* Remove deprecated Search SDKs (#37677)

Relates to #37660

* Refactor operation for new schema (#37657)

* Remove deprecated Graph SDK (#37673)

Relates to #37660

* Remove deprecated Event Grid SDK (#37671)

Relates to #37660

* Remove deprecated Container Registry SDK (#37670)

Relates to #37660

* Remove deprecated Attestation SDK (#37669)

Relates to #37660

* Remove deprecated Operational Insights SDK (#37668)

Relates to #37660

* Remove deprecated Application Insights SDK (#37667)

Relates to #37660

* `DataMovementTestBase` pull out shared functionality (#37493)

* move job part plan file utility out of testbase

* file util

* remove empty setup method

* pull out and rename enum

* remove dmlibtestbase from rehydrate tests

* remove recordings

* Set operation name for consumer spans (#37696)

* Set operation name for consumer spans

* refactor

* fix test

* DataMovement `DataTransfer` links back to owning `TransferManager` (#37695)

* add link DataTransfer -> TransferManager

* exportapi

* Juntuchen/callback uri override (#37652)

* added logic to pass callbackUri override

* updated api

* Update autorest.md

* Update autorest.md

* Azure OpenAI: add capabilities up through 2023-07-01-preview (#37539)

* squashed commit for omnibus changes

* restore stringent sig= sanitizers for image urls

* Update to consume content_filter_results in Completions; test support

* snap to official .tsp and add image generation model factory support

* swap chat tests to gpt-4 for contemporary Azure Chat Functions support

* codegen update: properly address optionality of filter categories for function_call responses via tsp

* add missing test recording

* Incorporate PR feedback using a new PR typespec commit hash. Thanks, Jose!

* merge #37536 changes

* PR feedback (+ analyzer accepts for var/not-var)

* Missing Role on modified test

* Add one more snippet collection, this time for Chat Functions

* proactive removal of GetStream helper; changelog; cleanup of unused code

* snap to latest merged .tsp (matching previous PR commit, should be no change whatsoever)

* PR feedback. Thank you yet again, Jose!

* Avoid test failures for known issue (#37714)

* Sync eng/common directory with azure-sdk-tools for PR 6530 (#37697)

* Update-DocsMsMetadata.ps1 can fail the build on invalid packages

* Better error handling and logging

* Review feedback

---------

Co-authored-by: Daniel Jurek <djurek@microsoft.com>

* Update location ip mapping (#37707)

* Update location ip mapping

* update changelog

* reword

* refactor

* address pr feedback

* remove client ip

* fix link issue

* finalize changelog for 2023-07 release (#37723)

* Mark internal classes sealed (#37724)

* Mark internal classes sealed

* exporters

* Dev credentials retain AuthenticationFailedException behavior outside of DAC (#37725)

* Enable customerizing webview for interactive authentication (#34095)

* update deps for spelling tool (#37728)

Co-authored-by: Jeff Fisher <jeffish@microsoft.com>

* Fall back to management link when settling non-session message (#37704)

* Fall back to management link when settling non-session message

* fix typo

* fix test

* Remove deprecated Purview SDK (#37675)

Relates to #37660

* Update Generator Version 3.0.0-beta.20230719.1 (#37731)

* [Core] Updating System.Diagnostics.DiagnosticSource types usage (#37661)

* last phase

* PR feedback

* fixing supports activity source method)

* simplifying dispose

* [ACS JobRouter Pre-release] Execute prelease script (#37594)

* missing usage of Azure.Etag in RouterQueueItem

* add features added section in changelog for pre-release script

* Pre-release

* fix typo

* update changelog

---------

Co-authored-by: williamzhao87 <williamzhao87@gmail.com>

* Use events for lock lost notification (#37643)

* Set up CI with Azure Pipelines

[skip ci]

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update LineCounter.csproj

* Update azure-pipelines.yml for Azure Pipelines

* Use events for lock lost notification

* docs

* docs

* PR fb

* Fix

* Ensure CT registration is disposed when callback completes

* Fix tests

* Remove superfluous registration

* Update sdk/servicebus/Azure.Messaging.ServiceBus/src/Processor/ProcessMessageEventArgs.cs

* Update docs

* Update AutoRest C# version to 3.0.0-beta.20230719.2 (#37743)

* Sync eng/common directory with azure-sdk-tools for PR 6544 (#37735)

* Only save package properties for track 2 packages (prevents overwrites of track 2 package info by track 1 packages)

* Only overwrite if the package is track 2

---------

Co-authored-by: Daniel Jurek <djurek@microsoft.com>

* Update AutoRest C# version to 3.0.0-beta.20230719.3 (#37746)

- Update Generator Version 3.0.0-beta.20230719.3
- Update SDK codes
- fix issues in `Azure.Communication.CallAutomation`
  - remove setting repeatability headers logic
  - remove `RepeatabilityHeaders` and its tests since it's not used anymore
- fix issues in `Azure.Communication.CallingServer`
  - fix wrong swagger definition for `Repeatability-First-Sent`
  - change test case base to add repeatability headers into `IgnoredHeaders`
  - update test recordings to add repeatability request headers
- fix issues in `Azure.Communication.Chat`
  - add customization codes to keep existing public interface which expose repeatability request id as parameter
  - regen codes
- fix broken codes in `Azure.Communication.Rooms`
- fix issues in `Azure.Health.Insights.CancerProfiling`
  - update API signature
  - add repeatability headers into `IgnoredHeaders` in test case
  - re-record test cases
- fix issues in `Azure.Health.Insights.ClinicalMatching`
  - update API signature
  - add repeatability headers into `IgnoredHeaders` in test case
  - re-record test cases
- fix api signature of `Azure.Analytics.Purview.Sharing`

---------

Co-authored-by: archerzz <archerzz@gmail.com>
Co-authored-by: Mingzhe Huang <archerzz@users.noreply.github.com>

* Update Content Safety sample1 analyze text (#37747)

* [Consumption] Fix `meterId` empty format issue (#37718)

* fix `meterId` empty format issue

* delete `mgmt-debug` config

* nullable all `meterID` related class

* add  PriceSheetProperties to nullable config

* Update CHANGELOG.md

* Update CHANGELOG.md

* Increment package version after release of Azure.AI.OpenAI (#37730)

* Update Generator Version 3.0.0-beta.20230720.1 (#37751)

* Updated client constructors to ensure authentication is property being added to ClientConfiguration (#37710)

* Revert bad merge (#37757)

* [JobRouter] Bug bash fixes (#37754)

* Addressed initial API review feedback (#37756)

* Remove deprecated Key Vault SDKs (#37665)

* Remove deprecated Key Vault SDKs

Relates to #37660

* Continue to ignore track 1 management until deprecated

* Move track 1 snippets to track 2

* Fix snippet compilation

* [Communication] Migrated recordings to the assets repo (#37711)

* Revert "[Communication] Migrated recordings to the assets repo (#37711)" (#37766)

This reverts commit ec6bc3b.

* Remove assertions from KV perf tests (#37762)

Fixes #29370

* [ElasticSan] Preview refresh of ElasticSan API version 2022-12-01 (#37717)

* preview refresh of ElasticSan

* ran export API

* Updated recording sessions

* update changelog

* generate sample code for mysql (#37365)

* Generate sample code for ResourceManager (#37550)

* Update AutoRest C# version to 3.0.0-beta.20230721.1 (#37770)

Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>

* [FormRecognizer] Cleaning up tests (1/?) (#37705)

* Storage STG 90 (#36974)

* Added migration guide (#37577)

* Migration guide added

Added migration guide from WindowsAzure.ServiceBus to Azure.Messaging.ServiceBus

* Update README.md

Added WindowsAzure.ServiceBus migration guide to README

* Update MigrationGuide-WindowsAzure-ServiceBus.md

Fixed typo

* Updated code snippets

* Update MigrationGuide-WindowsAzure-ServiceBus.md

* Apply suggestions from code review

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* Renamed migration guide for WindowsAzure.ServiceBus

* File rename

* Updated link to migration guide

* Update sdk/servicebus/Azure.Messaging.ServiceBus/MigrationGuide_WindowsAzureServiceBus.md

Co-authored-by: Madalyn Redding <66138537+m-redding@users.noreply.github.com>

---------

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Madalyn Redding <66138537+m-redding@users.noreply.github.com>

* Update README Mocking links (#37776)

* Update README Mocking links

* Fix broken docs link

* Fix for failing RenameAsync_SourceSasCredentialDestSasUri live tests (#37779)

* include AAD in the logger messages (#37782)

* Update CODEOWNERS for Identity (#37783)

* update swagger and add support for transfer in group call (#37701)

* update swagger and add support for transfer in group call

* add null check for event mapping

* update netstandard2.0.cs

* Update TransferToParticipantOptions.cs

fix comment format

* Update TransferToParticipantOptions.cs

remove tailing space

* [Storage] Migrating recordings to the assets repo (#37118)

* Edit pass on Azure.Identity troubleshooting guide (#37788)

* [OpenAI] Fix typo 'stanard' to 'standard' (#37791)

* Generate sample code for postgresql (#37399)

* generate sample for postgresql

* update samples

* update samples

* regenerate latest code and sample

* remove 'generated' folder

* add back Generated folder with correct case

* revert unnecessary change in mysql

* support generate samples for ArmResourceExtension's operation (#37685)

* Planned maintenance - package - 2023 - 04 (#34932)

* Update AutoRest C# version to 3.0.0-beta.20230723.1 (#37796)

* Increment package version after release of Azure.ResourceManager.Maintenance (#37799)

* Support DataFactoryElement in Sample Generation (#37774)

* Remove deprecated Web Sites SDK (#37680)

Relates to #37660

* Remove deprecated Traffic Manager SDK (#37679)

Relates to #37660

* add test for encryptiondata key casing (#37702)

* add AADSTS50020 to troubleshooting doc (#37786)

* Set DOCKER_BUILDKIT to 1 in stress deploy image build (#37785)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* Fix reclassify (#37810)

* Add samples demonstrating usage of lock lost events (#37814)

* Add samples demonstrating usage of lock lost events

* Update sdk/servicebus/Azure.Messaging.ServiceBus/samples/Sample13_AdvancedConfiguration.md

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* PR fb

* md file

---------

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* Make x509 certificate script from azure-sdk-for-net common to repos (#37811)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* Update mocking guidance links (#37806)

* Update mocking guidance links

* Delete unused code snippet

* [AzureMonitorExporter] Remove "sampleRate" tag from SamplingResult (#37765)

* remove sampling tag

* remove tag

* pr feedback: if != 100

* add extra check for SampleRate != 100f

* remove nullable from method paramaters. update tests.

* Upgrade autorest.csharp to 3.0.0-beta.20230724.1 (#37798)

* Update Generator Version 3.0.0-alpha.20230723.2

* Update SDK codes

* Update SDK codes

* update

* update

---------

Co-authored-by: pshao25 <97225342+pshao25@users.noreply.github.com>

* Increment package version after release of Azure.ResourceManager.GraphServices (#37822)

* Fix IMDS parsing invalid json (#37805)

* [JobRouter] Fix job/queue/worker updates (#37835)

* Update DataMovement READMEs (#37590)

* starting point readme

* re-added missed extensions samples

* handling failures

* fix readme verification

* fixes

* spelling

* add samples to validation

* update snippets base package

* blobs samples generated

* [Schema Registry] Add pluggable serializer (#36926)

* add code and tests

* updates

* new tests, doc updates, cleanup

* sample update

* move Lru cache to core

* API gen

* md updates

* doc

* trying to fix merge conflict

* feedback

* fix

* updating snippets

* Update sdk/core/Azure.Core/src/Serialization/SchemaValidator.cs

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* Apply suggestions from code review

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* feedback/ regenerating snippets

* removing unneeded md links

* Update sdk/schemaregistry/Azure.Data.SchemaRegistry/samples/Sample02_Serialization.md

Co-authored-by: Christopher Scott <chriscott@hotmail.com>

* WIP - feedback part 1

* updates

* additional tests, more feedback, api changes support

* trying to fix indentation

* trying to fix indentations 2

* pipeline fix

* test

* updating nullable annotations

* WIP feedback

* feedback 1

* feedback 2

* more feedback

* tweaking docs

* pipeline fixes

* change namespace from Azure.Core.Experimental to just Azure.Core

* fixes

* update exception logic

* update schema validator aggregate exception message

* test fix

* tweak sample

---------

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Christopher Scott <chriscott@hotmail.com>

* [AzureMonitorExporter] fix SDK version (#37807)

* fix SDK version

* guard against excessively length

* changelog

* add truncate

* changelog

* Added core types needed by CloudMachine incubation to Azure.Core.Experimental (#37787)

* Added core types needed by CloudMachine incubation

* removed config as it's harder than I thought and we don't need it now

* PR feedback

* PR feedback

* removed config package

* more PR feedback fixes

* PR feedback

* fixed test bug

* updated API files

* updates APIs

* [Service Bus] Migration guide tweaks (#37839)

* [Service Bus] Migration guide tweaks

The focus of these changes is to revise some of the phrasing and streamline
some of the explanations for migration scenarios.

* Fixing broken link

* Update sdk/servicebus/Azure.Messaging.ServiceBus/MigrationGuide.md

Co-authored-by: Christopher Scott <chriscott@hotmail.com>

* Fixing typo

---------

Co-authored-by: Christopher Scott <chriscott@hotmail.com>

* Update AutoRest C# version to 3.0.0-beta.20230725.1 (#37830)

* [AzureMonitorExporter] Integration of OpenTelemetry Resource Detectors (#37837)

* Add Resource Detector

* Update changelog

* SetResourceBuilder to ConfigureResource

* Fix test

* Update changelog

* Fix build issue.

* [JobRouter] Remove worker constructor (#37860)

* Move X509Certificate2 module to eng/common (#37812)

* Move X509Certificate2 module to eng/common

* Use eng/common certificate functions in keyvault test-resources-post.ps1

* Use PSScriptRoot for importing x509 module

* Sofiar/add pagination (#37856)

* Add pagination to endpoints and tests

* Add pagination tests

* Update recordings

* Update old recordings

* Remove unused test

* Add to ChangeLog

* Add validation for pages with less than 2 numbers

* Add geographic area codes as pages test

* Naive implementation of allowing env override (#37780)

* naive implementation of allowing env override

Co-authored-by: Christopher Scott <chriss@microsoft.com>

* [AzureMonitorExporter] Add Truncation to ContextTags (#37843)

* truncate Tags

* fix typo

* remove usused consts

* remove some Truncates

* apimanagement - 2022-08-01 - track1 sdk  (#34639)

* Update Generator Version 3.0.0-beta.20230726.2 (#37853)

* Remove deprecated Hybrid Data SDK (#37674)

Relates to #37660

* [FormRecognizer] Removed IgnoreServiceError attributes and overrode IsEnvironmentReady method (#37858)

* [Compute] API version 2023-01- 02 track2 (#37316)

* Increment package version after release of Azure.ResourceManager.DataProtectionBackup (#37871)

* Enabled STG 90 live tests (#37857)

* [Service Bus] ReadMe DI Snippets (#37863)

The focus of these changes is to convert the dependency injection examples
in the README to be snippet-driven.  In addition, an example for registering
SubClients was also added, as this has been a frequent inquiry.

* [AzureMonitorDistro] update resource detector (#37881)

* update resource detector

* changelog

* revent

* fix changelog

* Increase Rooms .Net SDK code coverage (#37866)

* Increase Rooms .Net SDK code coverage

* List Room get first two pages

---------

Co-authored-by: Minnie Liu <peiliu@microsoft.com>

* [ACS JobRouter] Execute prelease script (#37845)

* missing usage of Azure.Etag in RouterQueueItem

* add features added section in changelog for pre-release script

* Pre-release

* update changelog

* update changelog

* change release date to 27

---------

Co-authored-by: williamzhao87 <williamzhao87@gmail.com>

* Pass Assets Directory in CI (#37868)

* When running in CI, pass a different temp dir for each proxy invocation to clone assets within

* [Service Bus] Clarifiy ScheduledEnqueueTime (#37861)

* [Service Bus] Clarifiy ScheduledEnqueueTime 

The focus of these changes is to clarify how scheduled messages work.

* Increment package version after release of Azure.Communication.JobRouter (#37885)

* Migrated remaining recordings to the assets repo (#37838)

* Fix Delete Invalid Room Test case (#37887)

* Increase Rooms .Net SDK code coverage

* List Room get first two pages

* Fix delete invalid room test

* Remove unneeded recordings

---------

Co-authored-by: Minnie Liu <peiliu@microsoft.com>

* Remove workaround for common-types (#37875)

* prepare release for compute (#37895)

* Vbs elastic pool changes and regenerating sdk for sql (#37312)

* generate client code and add tests for vbs elastic pools

* add generated file

* add more generated files for fixing errors

* add more generated files for fixing errors

* fix failover group errors

* update autorest.md file

* fix pipeline errors

* Update samples

* Mitigate breaking changes, example pending change

* Update

* recordings pushed to assets repo

* minor

* Export API

* updated CHANGELOG

* remove session records folder

* add back tag

* Update

* revert not needed changes

* update

* Prepare release

* revert minor change

* address PR feedback

* new recordings pushed to assets repo

* address more feedback

* update

---------

Co-authored-by: Wei Hu <huwe@microsoft.com>

* [CosmosDB] Changes for Rest API Version 2023-03-15-preview (#36950)

* [CosmosDB] Changes for Rest API Version 2023-03-15-preview

* add tests for connection strings changes

* Save changes

* Save changes

* saving work

* saving work

* saving work

* saving work

* Save Recordings

* Save Recordings

* adding materializedview tests

* Save Recordings

* resolving comments

* Save changes

* Save changes

* Save Recordings

* Save Recordings

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* saving work

* Renames

* Operation Rename

* Address code comments.

* Address code changes.

* error fix.

* Export API

* Update

* rename ConnectionString

---------

Co-authored-by: Carolyn Jackson <carjackson@microsoft.com>
Co-authored-by: Chandrasekhar Gunturi <chguntur@microsoft.com>
Co-authored-by: Himanshu Sunil Dhawale <hidhawal@microsoft.com>
Co-authored-by: himanshudhawale <46133071+himanshudhawale@users.noreply.github.com>
Co-authored-by: Wei Hu <huwe@microsoft.com>

* Increment package version after release of Azure.ResourceManager.Compute (#37896)

* Mark NullableResponseOfT.Value as nullable (#35560)

* [ACS][CallAutomation] Updates to be aligned with GA version (#37543)

* Updates to be aligned with GA version

* ChannelAffinity access modifier update

* Updated api file

* Fixing tests

* Removed double newline

---------

Co-authored-by: Min Woo Lee 🧊 <77083090+minwoolee-ms@users.noreply.github.com>

* [Event Hubs] Move T1 migration guide snippets (#37908)

* [Event Hubs] Move T1 migration guide snippets

The focus of these changes is to move the migration snippets demonstrating
use of `Microsoft.Azure.EventHubs` to the `Azure.Messaging.EventHubs` test
projects.  This consolidates the build pipeline used for validating the
snippets and allows for removal of the T1 code once the library is formally
retired.

* Update Statsbeat attach allowed values (#37909)

* Sync eng/common directory with azure-sdk-tools for PR 6518 (#37706)

* Bump test proxy version
* remove interim fix
* move proxy transition-scripts folder to onboarding

Co-authored-by: Bill Wert <billwert@microsoft.com>
Co-authored-by: Scott Beddall <scbedd@microsoft.com>

* cleanup todos (#37913)

* Add Tests and Recordings for CallDialog API (#37663)

* Added dialog tests to SDK

* Updated live test and added recordings

* Added missing test cases for dialog api

* Added recordings to live tests

* Sanitize the botappid

* Updated tests and added working recordings

* Updated sanitizer and recordings

* Remove potentially conflicting sanitizer

* Updated sanitizer and recordings

* Revert "Updated sanitizer and recordings"

This reverts commit 8c71204.

* Revert "Remove potentially conflicting sanitizer"

This reverts commit d65ef0d.

* Revert "Updated sanitizer and recordings"

This reverts commit e0eb4e6.

* Updated sanitizer and recordings

* SDK Updated with latest version of Network cloud API 2023-07-01 (#37722)

* Release Azure.ResourceManager.ManagedNetworkFabric for first GA (#37726)

* Increment package version after release of Azure.ResourceManager.ManagedNetworkFabric (#37917)

* [Messaging] Mocking sample annotation (#37910)

The focus of these changes is to annotate the mocking samples for Event Hubs
and Service Bus with a call-out to the general Azure SDK unit testing and
mocking article.

While the article is focused around HTTP services and
does not replace these dedicated samples, the additional context and examples
may be helpful to developers.

* Tag Synapse.Artifacts to package-artifacts-composite-v7 (#37303)

* Tag Aynapse.Artifacts to package-artifacts-composite-v7

* Update

* update

* update

* update

* Add change log

* Add sdk change for nrp version 2023-04-01 (#37784)

* Increment version for cosmosdb releases (#37923)

* Prepare for release ElasticSan 1.0.0-beta.4 (#37926)

* Increment package version after release of Azure.ResourceManager.ElasticSan (#37929)

* Increment package version after release of Azure.Analytics.Synapse.Artifacts (#37924)

* Increment package version after release of Azure.ResourceManager.Sql (#37922)

* Increment package version after release of Azure.ResourceManager.Network (#37931)

* [AzureMonitorExporter] cleanup Todos (part2): add EventSource to AspNetCore (#37914)

* add EventSource to AspNetCore and cleanup

* update message

* Add Standard metrics for messaging (#37940)

* standard metrics for messaging

* revert change

* Added support for `BlobsOptions.MaxDequeueCount` (#37836)

* [OpenAI] Improve treatment of connection exceptions during streaming (#37888)

* Add AMQP constructor to ServiceBusMessage (#37951)

* Fixed issue where pagianted parameter was being sent with DataLakeFil… (#37934)

* Added RehydratePendingToCold to ArchiveStatus (#37889)

* Add support for custom objects within the dialogContext (#37947)

* Sync eng/common directory with azure-sdk-tools for PR 6611 (#37938)

* update dotnet dev cert being shipped with the proxy to renew for another year
* update suppression file

---------

Co-authored-by: Scott Beddall <scbedd@microsoft.com>

* Abdulhakim/Do not allow null or empty actions (#37737)

* Marked empty/null actions as failed

* replaced tabs with spaces

* Updated spacing

* Replaced tab with spaces

* Updates based on feedback

* Updated Validation Logic

* WIP Added test cases for OneOrMoreRequiredAttribute

* Added test case for EnumberableItemsNotNull Attribute

* Feedback updates

* Updates based on PR feedback

* Sort 'using' lists and removed unapplicable data annotation

* Adding necessary updates to merge with azure main

* Removed xUnit reference now that we are using NUnit tests

* removed Update-Snippets.ps1 changes and will rebase

* Removing requirement for response object in request to not perform early validation

* Added null check and test for response before marking as failed

* Updated exception to validation exception and corrected test

* Changed back to argument null exception

* Added response validation exception type

* Ran script to add partial class for ResponseValidationException

* Update sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/AuthenticationEventResource.resx

Adding a missing period

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* Added period

---------

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* [Search] Vector Search Updates For August Preview (#37948)

Vector Search updates

* Update Generator Version 3.0.0-beta.20230801.1 (#37959)

* [StorageMover] Upgrade to API version 2023-07-01-preview  (#37928)

* [DataFactory] Polish and prepare for new beta release (#37958)

* Increment package version after release of Azure.ResourceManager.DataFactory (#37981)

* Enable IdenticalDialogsTest and add Recordings (#37976)

* Use TrySetCanceled and TrySetResult to avoid finalizing the task twice (#37984)

* Mark package as In Release (#37990)

* Update azd credential order in DAC (#37986)

* extra logging for PartialSuccess (#37915)

* [AzureMonitorExporter] api feedback (#37996)

* merge Extensions classes

* update Options class

* changelog

* update public api

* remove nullables from public api

* changelog

* changelog

* export public api

* reset enum integer

* Update AutoRest C# version to 3.0.0-beta.20230801.2 (#37974)

* Update Generator Version 3.0.0-beta.20230801.2

* Update SDK codes

* Update SDK samples m*,n*,o*,p*,q*,r*

* Rename and update

---------

Co-authored-by: Wei Hu <huwe@microsoft.com>

* Update AutoRest C# version to 3.0.0-beta.20230803.1 (#38003)

* Update Generator Version 3.0.0-beta.20230803.1

* Update SDK codes

* Update SDK codes

* Update SDK codes

* Update SDK codes

* Workload Identity Support for AzureComponentFactory (#37944)

* First pass

* Updated changelog and added comment

* Update sdk/extensions/Microsoft.Extensions.Azure/CHANGELOG.md

---------

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* [Storage] [DataMovement] Renamed API from API Arch Board Feedback (#37935)

* Renamed API from API Arch Board Feedback

* Export API and Update Snippetes

* Ignore new sample tests (#38005)

* [DO NOT MERGE]Per-action callback Uri feature name updates (#37842)

* name update

* fixed a bug

* Entra - Make Source field in payload required (#37966)

* Marked empty/null actions as failed

* replaced tabs with spaces

* Updated spacing

* Replaced tab with spaces

* Updates based on feedback

* Updated Validation Logic

* WIP Added test cases for OneOrMoreRequiredAttribute

* Added test case for EnumberableItemsNotNull Attribute

* Feedback updates

* Updates based on PR feedback

* Sort 'using' lists and removed unapplicable data annotation

* Adding necessary updates to merge with azure main

* Removed xUnit reference now that we are using NUnit tests

* removed Update-Snippets.ps1 changes and will rebase

* Added null check and test for response before marking as failed

* Updated exception to validation exception and corrected test

* Changed back to argument null exception

* Added response validation exception type

* Update sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/AuthenticationEventResource.resx

Adding a missing period

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* Added period

* Added not null check for source field in payload

* Changed source attribute to required

* Sorted usings

* Added test scenarios for AuthenticationEventMetadata

* Added big fix to changelog

* Refactored test case for consistency with existing tests and added links to changelog

* Added assertions for exception messages and removed links to bugs

* Ran scripts to update netstandard2.0 class

---------

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>

* Sync eng/common directory with azure-sdk-tools for PR 6670 (#38008)

* bump the proxy version

* updating version proxy consumed by framework

---------

Co-authored-by: Scott Beddall <scbedd@microsoft.com>

* Enable Test Proxy logging in Test Framework (#37994)

* Add AMQP constructor to ServiceBusMessage

* Enable logging for test proxy integration

* Clean up

* readme

* add section

* revert default

* Add locking

* Add AspNetCore Info logging

* reduce delay to 20ms

* Put all proxy logging behind flag instead of allowing loglevel config

* Fix wrapping

* Split out CheckForErrors to make it sync

* [AzureMonitorExporter] Refactor Environment Variables (#38012)

* refactor Env Vars

* cleanup

* Upgrade containerapps SDK to 2023-04-01-preview (#37930)

* upgrade

* update

* update

* fix ci

* Update AutoRest C# version to 3.0.0-beta.20230804.1 (#38029)

Co-authored-by: Arcturus Zhang <dapzhang@microsoft.com>

* Update AuthenticationEventMetadataTests.cs (#38038)

Fixing a string that, while local only to the test instance, contains a secret that is causing security alerts.

* Fix MessageLockLost event test (#38021)

* Fix MessageLockLost event test

* wrap in try/finally

* Don't close the receiver/processor when StopAsync is called (#38035)

* Enable Server Busy test (#38043)

* [ACS][GA1] Clean Commit (#36550)

* clean commit

* Updated comments on start recording options

---------

Co-authored-by: Min Woo Lee 🧊 <77083090+minwoolee-ms@users.noreply.github.com>

* add single playsource PlayOptions constructor overload (#36825)

* fix playtoalloptions error

* update api surface

* Updating verison name

* Increment package version after release of Azure.Communication.CallAutomation (#37059)

* Callautomation/release/beta2 features (#37485)

Beta 2 features implementation of PMA BETA2_2023_06_15_preview contract:

SendDtmf
DtmfSubscription
PlayTTS
PlaySSML
Recognize Choices
Recognize Freeform
Mute
BYO Cogsvc changes for Answer/CreateCall

* Beta 2 feedback changes(sdk specific only) (#37876)

* Beta 2 feedback changes(sdk specific only)

* make remaining ABR updates

* update media event reason codes

* address pr comments

* update tests

---------

Co-authored-by: abhishesingh-msft <abhishesingh@microsoft.com>
Co-authored-by: Adam Tazi <adamtazi@microsoft.com>

* Updated autorest generated code as per beta2 swagger

* Removed unwated classes and updaed some classes as per beta2

* Updated sendDtmfTones tests

* Removed ApiCompatVersion

* Fixed buid issues

* Renamed class to CommunicationCallAutomationModelFactory

* Updated API contract

* Updated live tests

---------

Co-authored-by: Jesse Squire <jsquire@microsoft.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
Co-authored-by: reutgross <104348031+reutgross@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com>
Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com>
Co-authored-by: Timothy Mothra <tilee@microsoft.com>
Co-authored-by: williamzhao87 <williamzhao87@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Aleksandr Riabov <106100749+aleksriabov@users.noreply.github.com>
Co-authored-by: Wei Hu <live1206@gmail.com>
Co-authored-by: Fang Chen - Microsoft <fanche@microsoft.com>
Co-authored-by: Ray Chen <raychen@microsoft.com>
Co-authored-by: RichardAtMoverDk <126064394+RichardAtMoverDk@users.noreply.github.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: Caio Saldanha <camaiaor@microsoft.com>
Co-authored-by: James Suplizio <jasupliz@microsoft.com>
Co-authored-by: Vibhuti-Sharma-Microsoft <vibsharm@microsoft.com>
Co-authored-by: amatukmolina <81262128+amatukmolina@users.noreply.github.com>
Co-authored-by: Wei Hu (from Dev Box) <huwe@microsoft.com>
Co-authored-by: Madalyn Redding <66138537+m-redding@users.noreply.github.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Arthur Ma <arthurma@microsoft.com>
Co-authored-by: mcgallan <88413158+mcgallan@users.noreply.github.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
Co-authored-by: Ming Han Teh <teh_minghan@hotmail.com>
Co-authored-by: Weihan Li <weihanli@outlook.com>
Co-authored-by: Amanda Nguyen <48961492+amnguye@users.noreply.github.com>
Co-authored-by: ambrahma <61298407+ambrahma@users.noreply.github.com>
Co-authored-by: Chengming <v-cruan@microsoft.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>
Co-authored-by: David R. Williamson <14119884+drwill-ms@users.noreply.github.com>
Co-authored-by: Jocelyn <41338290+jaschrep-msft@users.noreply.github.com>
Co-authored-by: Juntu Chen <95723208+juntuchen-msft@users.noreply.github.com>
Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>
Co-authored-by: Jeff Fisher <jeffish@microsoft.com>
Co-authored-by: williamzhao87 <williamzhao87@gmail.com>
Co-authored-by: archerzz <archerzz@gmail.com>
Co-authored-by: Mingzhe Huang <archerzz@users.noreply.github.com>
Co-authored-by: MinjueWu <597922968@qq.com>
Co-authored-by: Chengming <61542202+dvbb@users.noreply.github.com>
Co-authored-by: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com>
Co-authored-by: yifanz7 <131133995+yifanz7@users.noreply.github.com>
Co-authored-by: Rodge Fu <fwj_ac@msn.com>
Co-authored-by: Eldert Grootenboer <eldert@eldert.net>
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: huachuandeng <73561849+huachuandeng@users.noreply.github.com>
Co-authored-by: CT <shrgholami@gmail.com>
Co-authored-by: Harshit Shrivastava <harshits@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: pshao25 <97225342+pshao25@users.noreply.github.com>
Co-authored-by: Christopher Scott <chriscott@hotmail.com>
Co-authored-by: Krzysztof Cwalina <kcwalina@microsoft.com>
Co-authored-by: sofiar-msft <sofiar@microsoft.com>
Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
Co-authored-by: Haider Agha <64601174+haagha@users.noreply.github.com>
Co-authored-by: minnieliu <minnieliu96@hotmail.com>
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
Co-authored-by: vidit-msft <78883096+vidit-msft@users.noreply.github.com>
Co-authored-by: Srinikhil Naravamakula <srinikhil.r@gmail.com>
Co-authored-by: Carolyn Jackson <carjackson@microsoft.com>
Co-authored-by: Chandrasekhar Gunturi <chguntur@microsoft.com>
Co-authored-by: Himanshu Sunil Dhawale <hidhawal@microsoft.com>
Co-authored-by: himanshudhawale <46133071+himanshudhawale@users.noreply.github.com>
Co-authored-by: minwoolee-msft <77083090+minwoolee-msft@users.noreply.github.com>
Co-authored-by: Min Woo Lee 🧊 <77083090+minwoolee-ms@users.noreply.github.com>
Co-authored-by: Bill Wert <billwert@microsoft.com>
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
Co-authored-by: calvinkwtang <calvintang@microsoft.com>
Co-authored-by: Priya Shet <priya.shet@gmail.com>
Co-authored-by: Mohana-Krishna-Nali <117837369+Mohana-Krishna-Nali@users.noreply.github.com>
Co-authored-by: Joanna-Yang-Art <137839107+Joanna-Yang-Art@users.noreply.github.com>
Co-authored-by: hakimms <131916587+hakimms@users.noreply.github.com>
Co-authored-by: Marcin Elantkowski <marcin.elantkowski@gmail.com>
Co-authored-by: Will Sugarman <will.sugarman@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Adam Tazi <89811028+atazimsft@users.noreply.github.com>
Co-authored-by: Adam Tazi <adamtazi@microsoft.com>
Co-authored-by: abhishesingh-msft <123186776+abhishesingh-msft@users.noreply.github.com>
Co-authored-by: abhishesingh-msft <abhishesingh@microsoft.com>
@m-redding m-redding mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annelo-msft annelo-msft annelo-msft left review comments

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@jsquire jsquire jsquire approved these changes

@christothes christothes christothes approved these changes

@lmolkova lmolkova lmolkova approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@serkantkaraca serkantkaraca Awaiting requested review from serkantkaraca

Assignees
No one assigned
Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@m-redding @azure-sdk @lmolkova @jsquire @christothes @annelo-msft @JoshLove-msft