Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableClient.CreateIfNotExists / TableClient.CreateIfNotExistsAsync documentation corrected #32843

Merged

Conversation

radekfojtik
Copy link
Contributor

TableClient.CreateIfNotExists / TableClient.CreateIfNotExistsAsync documentation corrected (methods do not return null if the table already exists)

Anyway, this change #30849 is, in my opinion, questionable. For example

  • BlobContainerClient.CreateIfNotExists still returns NULL if container already exists
  • QueueClient.CreateIfNotExists still returns NULL if the queue already exists

It would be nice to have this unified (as it has been in the past).

…cumentation corrected

Signed-off-by: radekfojtik <68660951+radekfojtik@users.noreply.github.com>
@ghost ghost added Tables customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Thank you for your contribution @radekfojtik! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Dec 2, 2022
@christothes
Copy link
Member

TableClient.CreateIfNotExists / TableClient.CreateIfNotExistsAsync documentation corrected (methods do not return null if the table already exists)

Anyway, this change #30849 is, in my opinion, questionable. For example

  • BlobContainerClient.CreateIfNotExists still returns NULL if container already exists
  • QueueClient.CreateIfNotExists still returns NULL if the queue already exists

It would be nice to have this unified (as it has been in the past).

Thanks for this PR!

Regarding the inconsistent behavior with Blob and Queue clients, they should actually conform this this new behavior. See #25626 for details.

@radekfojtik
Copy link
Contributor Author

@microsoft-github-policy-service agree

@radekfojtik
Copy link
Contributor Author

@christothes thanks for the information

@christothes christothes merged commit fd1564a into Azure:main Dec 2, 2022
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants