Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added StyleCop #327

Merged
merged 2 commits into from
Nov 27, 2013
Merged

Added StyleCop #327

merged 2 commits into from
Nov 27, 2013

Conversation

stankovski
Copy link
Member

Added StyleCop binaries and Settings.StyleCop

Added StyleCop import statement to Common.Tracing.Etw.csproj
Added FxCop and StyleCop analysis to Common
@ogail
Copy link
Contributor

ogail commented Nov 27, 2013

LGTM

<BooleanProperty Name="Enabled">False</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="FileHeaderMustHaveValidCompanyText">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want this off ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great validation, however, unfortunately, it check for the explicit tag:

//-----------------------------------------------------------------------
// <copyright file="Widget.cs" company="My Company">
//     Custom company copyright tag.
// </copyright>
//-----------------------------------------------------------------------

stankovski added a commit that referenced this pull request Nov 27, 2013
@stankovski stankovski merged commit 458c62c into Azure:dev Nov 27, 2013
@stankovski stankovski deleted the stylecop branch November 27, 2013 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants