Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Security Center - Updating multiple scenarios #27693

Closed
wants to merge 3 commits into from

Conversation

nitsi
Copy link

@nitsi nitsi commented Mar 22, 2022

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Updating / Adding

  • Alerts
  • Assessments
  • AssessmentsMetadata
  • Pricings
  • CustomAssessmentAutomations
  • CustomEntityStoreAssignments
  • MdeOnboardings
  • SecurityConnectors

@nitsi
Copy link
Author

nitsi commented Mar 23, 2022

/check-enforcer evaluate

@nitsi
Copy link
Author

nitsi commented Mar 23, 2022

@m-nash it seems that the check-enforcer is stuck on "In Progress" can you help?

…ersion.

Adding CustomAssessmentAutomations / CustomEntityStoreAssignments / MdeOnboardings / SecurityConnectors new capabilities.
Fixing unit tests
@nitsi nitsi changed the title Azure Security Center - Security Alert Added Simulate Method Azure Security Center - Updating multiple scenarios Mar 23, 2022
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

@nitsi
Copy link
Author

nitsi commented Mar 24, 2022

/check-enforcer evaluate

@nitsi
Copy link
Author

nitsi commented Mar 27, 2022

@m-nash can you please review?

@nitsi
Copy link
Author

nitsi commented Apr 18, 2022

@m-nash please hold merging, we are having an internal discussion about the location braking changes

@nitsi
Copy link
Author

nitsi commented May 19, 2022

@m-nash after a long internal discussion we decided to continue with this PR changes, can you please review?
I have answered the other questions above.

@m-nash m-nash assigned archerzz and unassigned m-nash May 23, 2022
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitsi AzSDK.RP.Props and AssemblyInfo.cs must be updated. Please see the guide.

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Jul 29, 2022
@ghost
Copy link

ghost commented Jul 29, 2022

Hi @nitsi. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Aug 5, 2022
@ghost
Copy link

ghost commented Aug 5, 2022

Hi @nitsi. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants