Add RequestOptions to Azure.Core #27149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
annelo-msft
requested review from
KrzysztofCwalina,
tg-msft,
JoshLove-msft and
christothes
as code owners
|
API changes have been detected in |
|
API changes have been detected in API changes - public class RequestOptions {
- public RequestOptions();
- public ErrorOptions ErrorOptions { get; set; }
- public void AddPolicy(HttpPipelinePolicy policy, HttpPipelinePosition position);
- }
- }
- }
- namespace Azure.Core.Pipeline {
- public static class HttpPipelineExtensions {
- public static HttpMessage CreateMessage(this HttpPipeline pipeline, RequestOptions? options); |
christothes
approved these changes
Feb 22, 2022
|
API changes have been detected in |
jsquire
reviewed
Feb 23, 2022
|
API changes have been detected in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so RequestOptions can be used by Gen 1 Generated Clients and not have ambiguity in the method signature regarding which CancellationToken takes precedence, whether two CTs are joined, etc.
Fixes Azure/autorest.csharp#1666