Remove LINQ allocations for all batched sends

[danielmarbach]

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

• Please open PR in Draft mode if it is:
  • Work in progress or not intended to be merged.
  • Encountering multiple pipeline failures and working on fixes.
• If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
• I have read the contribution guidelines.
• The pull request does not introduce breaking changes.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

SDK Generation Guidelines

• The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
• The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

• Include updated management metadata.
• Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

• If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

• If the check fails at the Verify Code Generation step, please ensure:

  • Do not modify any code in generated folders.
  • Do not selectively include/remove generated files in the PR.
  • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
    Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

  Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

    `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
  

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

[ghost]

Thank you for your contribution @danielmarbach! We will review the pull request and get back to you soon.

[danielmarbach]

@JoshLove-msft @jsquire if I didn't screw things up this will be a pretty nice allocation improvement. Need to stop though for today. If you are planning to "sneak" this in too, feel free to edit the PR directly.

[JoshLove-msft]

@JoshLove-msft @jsquire if I didn't screw things up this will be a pretty nice allocation improvement. Need to stop though for today. If you are planning to "sneak" this in too, feel free to edit the PR directly.

Thanks @danielmarbach! For this one, I think we can wait until the next release as I've already started the release pipeline.
I'd also be interested in whether these improvements also apply to Event Hubs /cc @jsquire

[jsquire]

I probably won't get a chance to dig into this until tomorrow, but at a glance it's something I can likely apply to Event Hubs as well... so double win!

[danielmarbach]

Now that we return a proper materialized list from the batches, it would also be possible to switch for example the DiagnosticExtensions away from using IEnumerable to clearly indicate there will be no multiple enumeration problem. Should I do that too?

[jsquire]

LGTM. Thanks, @danielmarbach! I'll let Josh have the final word.

[jsquire]

Now that we return a proper materialized list from the batches, it would also be possible to switch for example the DiagnosticExtensions away from using IEnumerable to clearly indicate there will be no multiple enumeration problem. Should I do that too?

I vote yes. I don't see us needing to loosen that guarantee.

[JoshLove-msft]

/azp run net - servicebus - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[danielmarbach]

Green 🥳 🎉

[danielmarbach]

Let me know about the other comments. Can push it here or do another PR. Fine for me either way

[JoshLove-msft]

/azp run net - servicebus - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).