Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QualityForRecognition to Face Detection #25242

Closed
wants to merge 4 commits into from
Closed

Add QualityForRecognition to Face Detection #25242

wants to merge 4 commits into from

Conversation

msyache
Copy link
Contributor

@msyache msyache commented Nov 10, 2021 •
edited
Loading

Added the optional attribute QualityForRecognition to Face Detection API.
Also includes some document discrepancy bugfixes.
Related swagger change PR:
Azure/azure-rest-api-specs#14556
Azure/azure-rest-api-specs#15187
Azure/azure-rest-api-specs#16449

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@msyache
Add QualityForRecognition to Face Detection
2447e28 
Added the optional attribute QualityForRecognition to Face Detection
API.
Also includes some document discrepancy bugfixes.
@jsquire jsquire deleted the branch Azure:feature/face/public-preview November 22, 2021 20:46
@jsquire jsquire closed this Nov 22, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Aug 22, 2023
@pdaru @NickKeller
@jaiveerk @jatakiajanvi12 @matthchr @wenjungaogaogao @norshtein @sallasindhuja @huizhifan @SanyaKochhar
CodeGen from PR 25254 in Azure/azure-rest-api-specs
5519e82 
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-07-02-preview (Azure#25254)

* Adds base for updating Microsoft.ContainerService/aks from version preview/2023-06-02-preview to version 2023-07-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#25049)

* add new field resourceUID to managed cluster properties (Azure#25069)

* add new field resourceUID to managed cluster properties

https://msazure.visualstudio.com/CloudNativeCompute/_git/aks-rp/pullrequest/8416789

* update description

* Mark guardrailsProfile Version as not required (Azure#25081)

* Mark guardrailsProfile Version as not required

* Run prettier

---------

Co-authored-by: Nick Keller <nickkeller@nickmsftlaptop.lan>

* Swagger Changes for Multiple DNS Zones for Web App Routing (Azure#25064)

* added web app routing changes for multiple dns zones

* modified examples

* Changes for unified azuremonitorprofile in Microsoft.ContainerService (Azure#25063)

* Changes for unified azuremonitorprofile

* Update prettier changes

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>

---------

Co-authored-by: Janvi Jatakia (from Dev Box) <jajataki@microsoft.com>
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>

* Add cost analysis to AKS preview Swagger (Azure#25082)

* update preview API to follow GA api - use one forceupgrade boolean in… (Azure#25099)

* update preview API to follow GA api - use one forceupgrade boolean instead of multiple overrides

* update msg

---------

Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>

* Mark trusted access role binding PUT and DELETE operation as async (Azure#25112)

* Mark trusted access role binding PUT and DELETE operation as async

* fix CI: update TA oepration's error to common type error

* Swagger for Machine API (Azure#25180)

* Swagger for Machine List, Get API

Related work items: #24759018

* Update managedClusters.json

* Update managedClusters.json

* Update MachineGet.json

adding new line

* Update MachineList.json

* Update managedClusters.json

* Update managedClusters.json

* Update managedClusters.json

* swagger: machine api

* swagger: machine api

* swagger:machine api

* swagger: machine api

* swagger: machine api

* swagger: machine api

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>

* swagger: machine api

* swagger: machine api

* swagger:  machine api

* swagger:machine api

* swagger:machine api

* swagger:machine api

---------

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>

* Adding Guardrails version to public swagger (Azure#25085)

* Adding Guardrails version to public swagger

* renamed GetGuardrailsVersions.json

* Applied GetCollectionResponseSchema rule

* Ran prettier fix

* Minor change

* moving parametre into managedClusters.json

* GuardrailsAvailableVersion model change

* Updated version param reference

* Swagger SemanticValidation fix

* model changes

* prettier fix

* Added version in list response

* Changed  to resource in GET and added descriptions where needed

* Removed identifier in GuardrailsAvailableVersionsList

---------

Co-authored-by: Sindhuja Salla <sisalla@microsoft.com>

* Remove overlay vpa unused properties (Azure#25242)

* remove unused properties

* only remove from required section

* remove the whole properties

---------

Co-authored-by: zhifanhui <zhifanhui@microsoft.com>

* asm: update examples to use asm- prefix for revisions (Azure#25247)

* Revert "Mark trusted access role binding PUT and DELETE operation as async (Azure#25112)" (Azure#25233)

This reverts commit db24ef8bfbf6b214310af0872a923130e27ae1b6.

* fix AgentPoolNameParameter location

* Fuming zhang containerservice microsoft.container service 2023 07 02 preview (Azure#25433)

* adding requested properties.

* adding requested properties

* prettier check

* removing read-only constraint

---------

Co-authored-by: daru__ <ptd2108@columbia.edu>
Co-authored-by: Nick Keller <keller.nicholas@outlook.com>
Co-authored-by: Nick Keller <nickkeller@nickmsftlaptop.lan>
Co-authored-by: Jaiveer Katariya <35347859+jaiveerk@users.noreply.github.com>
Co-authored-by: Janvi Jatakia <jatakiajanvi12@gmail.com>
Co-authored-by: Janvi Jatakia (from Dev Box) <jajataki@microsoft.com>
Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>
Co-authored-by: Wenjun Gao <wenjungaoat@gmail.com>
Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
Co-authored-by: Tongyao Si <tosi@microsoft.com>
Co-authored-by: sushmak295 <sushmak295@gmail.com>
Co-authored-by: sallasindhuja <114891776+sallasindhuja@users.noreply.github.com>
Co-authored-by: Sindhuja Salla <sisalla@microsoft.com>
Co-authored-by: huizhifan <60024380+huizhifan@users.noreply.github.com>
Co-authored-by: zhifanhui <zhifanhui@microsoft.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msyache @jsquire