Make Response.IsError functional for clients #24247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
requested review from
KrzysztofCwalina and
pakrym
as code owners
ghost
added
the
pakrym
approved these changes
Sep 27, 2021
|
Test? |
Message: |
|
Do we have a test for the error scenario? |
CannotGetOutputModelOnFailureCodeAsync is intended to do this, but is there a case you're thinking of that's not covered here? Happy to add... |
|
That test throws inside the client. Do we have one that throws in the cast operator? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this in the last IsError PR. Fixes #24225
As long as
Response.IsErrorlives in Azure.Core.Experimental, we'll need to add theResponsePropertiesPolicyto LLC clients' pipelines in their constructors, as we're doing here. When this functionality moves into Azure.Core, we can add this to PipelineBuilder.