Implement Response.IsError

sdk/core/Azure.Core/api/Azure.Core.net461.cs

@@ -198,6 +198,7 @@ protected Response() { }
         public virtual System.BinaryData Content { get { throw null; } }
         public abstract System.IO.Stream? ContentStream { get; set; }
         public virtual Azure.Core.ResponseHeaders Headers { get { throw null; } }
+        public bool IsError { get { throw null; } protected set { } }
         public abstract string ReasonPhrase { get; }
         public abstract int Status { get; }
         protected internal abstract bool ContainsHeader(string name);

sdk/core/Azure.Core/api/Azure.Core.net5.0.cs

@@ -198,6 +198,7 @@ protected Response() { }
         public virtual System.BinaryData Content { get { throw null; } }
         public abstract System.IO.Stream? ContentStream { get; set; }
         public virtual Azure.Core.ResponseHeaders Headers { get { throw null; } }
+        public bool IsError { get { throw null; } protected set { } }
         public abstract string ReasonPhrase { get; }
         public abstract int Status { get; }
         protected internal abstract bool ContainsHeader(string name);

sdk/core/Azure.Core/api/Azure.Core.netcoreapp2.1.cs

@@ -198,6 +198,7 @@ protected Response() { }
         public virtual System.BinaryData Content { get { throw null; } }
         public abstract System.IO.Stream? ContentStream { get; set; }
         public virtual Azure.Core.ResponseHeaders Headers { get { throw null; } }
+        public bool IsError { get { throw null; } protected set { } }
         public abstract string ReasonPhrase { get; }
         public abstract int Status { get; }
         protected internal abstract bool ContainsHeader(string name);

sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs

@@ -198,6 +198,7 @@ protected Response() { }
         public virtual System.BinaryData Content { get { throw null; } }
         public abstract System.IO.Stream? ContentStream { get; set; }
         public virtual Azure.Core.ResponseHeaders Headers { get { throw null; } }
+        public bool IsError { get { throw null; } protected set { } }
         public abstract string ReasonPhrase { get; }
         public abstract int Status { get; }
         protected internal abstract bool ContainsHeader(string name);

sdk/core/Azure.Core/src/Pipeline/HttpPipeline.cs

@@ -70,7 +70,9 @@ public ValueTask SendAsync(HttpMessage message, CancellationToken cancellationTo
         {
             message.CancellationToken = cancellationToken;
             AddHttpMessageProperties(message);
-            return _pipeline.Span[0].ProcessAsync(message, _pipeline.Slice(1));
+            var value = _pipeline.Span[0].ProcessAsync(message, _pipeline.Slice(1));
+            message.Response.EvaluateError(message);
+            return value;
         }
 
         /// <summary>
@@ -83,6 +85,7 @@ public void Send(HttpMessage message, CancellationToken cancellationToken)
             message.CancellationToken = cancellationToken;
             AddHttpMessageProperties(message);
             _pipeline.Span[0].Process(message, _pipeline.Slice(1));
+            message.Response.EvaluateError(message);
         }
         /// <summary>
         /// Invokes the pipeline asynchronously with the provided request.

sdk/core/Azure.Core/src/Response.cs

@@ -111,6 +111,16 @@ public virtual BinaryData Content
         /// <returns>The <see cref="IEnumerable{T}"/> enumerating <see cref="HttpHeader"/> in the response.</returns>
         protected internal abstract IEnumerable<HttpHeader> EnumerateHeaders();
 
+        /// <summary>
+        /// Indicates whether this response is an error, according to the REST API.
+        /// </summary>
+        public bool IsError { get; protected set; }
+
+        internal void EvaluateError(HttpMessage message)
+        {
+            IsError = message.ResponseClassifier.IsErrorResponse(message);
+        }
+
         /// <summary>
         /// Creates a new instance of <see cref="Response{T}"/> with the provided value and HTTP response.
         /// </summary>

sdk/core/Azure.Core/tests/PipelineTests.cs

@@ -58,6 +58,54 @@ public void TryGetPropertyIsCaseSensitive()
             Assert.False(message.TryGetProperty("SomeName", out _));
         }
 
+        [Test]
+        public async Task PipelineSetsResponseIsErrorTrue()
+        {
+            var mockTransport = new MockTransport(
+                new MockResponse(500));
+
+            var pipeline = new HttpPipeline(mockTransport);
+
+            Request request = pipeline.CreateRequest();
+            request.Method = RequestMethod.Get;
+            request.Uri.Reset(new Uri("https://contoso.a.io"));
+            Response response = await pipeline.SendRequestAsync(request, CancellationToken.None);
+
+            Assert.IsTrue(response.IsError);
+        }
+
+        [Test]
+        public async Task PipelineSetsResponseIsErrorFalse()
+        {
+            var mockTransport = new MockTransport(
+                new MockResponse(200));
+
+            var pipeline = new HttpPipeline(mockTransport);
+
+            Request request = pipeline.CreateRequest();
+            request.Method = RequestMethod.Get;
+            request.Uri.Reset(new Uri("https://contoso.a.io"));
+            Response response = await pipeline.SendRequestAsync(request, CancellationToken.None);
+
+            Assert.IsFalse(response.IsError);
+        }
+
+        [Test]
+        public async Task CustomClassifierSetsResponseIsError()
+        {
+            var mockTransport = new MockTransport(
+                new MockResponse(404));
+
+            var pipeline = new HttpPipeline(mockTransport, responseClassifier: new CustomResponseClassifier());
+
+            Request request = pipeline.CreateRequest();
+            request.Method = RequestMethod.Get;
+            request.Uri.Reset(new Uri("https://contoso.a.io"));
+            Response response = await pipeline.SendRequestAsync(request, CancellationToken.None);
+
+            Assert.IsFalse(response.IsError);
+        }
+
         private class CustomResponseClassifier : ResponseClassifier
         {
             public override bool IsRetriableResponse(HttpMessage message)