Renamed TranslationFilter and DocumentFilter to Get[Translation/Document]StatusesOptions #23336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedLeithy
requested review from
KrzysztofCwalina,
maririos and
tg-msft
as code owners
maririos
approved these changes
Aug 16, 2021
sdk/translation/Azure.AI.Translation.Document/src/GetDocumentStatusesOptions.cs
Show resolved
Hide resolved
I agree with your decision. Let's leave those types as is |
|
Without the customized model, the generated filter is already internal. So I removed |
maririos
approved these changes
Aug 18, 2021
AhmedLeithy
requested review from
AlexGhiondea,
chidozieononiwu,
christothes,
cijothomas,
danieljurek,
heaths,
JoshLove-msft,
jsquire,
Mohit-Chakraborty,
orenmichaely,
pakrym,
rajkumar-rangaraj,
reyang,
schaabs,
serkantkaraca,
TimothyMothra,
tyclintw,
vishweshbankwar and
weshaggard
as code owners
jsquire
requested changes
Aug 19, 2021
AhmedLeithy
force-pushed
the
DT-RenamingFilter
branch
from
e15ba97 to
c2ce34f
Compare
Done! Apologies. |
jsquire
approved these changes
Aug 19, 2021
maririos
removed request for
tg-msft,
christothes,
heaths,
pakrym,
danieljurek,
cijothomas,
Mohit-Chakraborty,
AlexGhiondea,
weshaggard,
rajkumar-rangaraj,
KrzysztofCwalina,
schaabs,
serkantkaraca,
reyang,
vishweshbankwar,
tyclintw,
TimothyMothra,
chidozieononiwu,
orenmichaely and
JoshLove-msft
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Apr 12, 2023
[Hub Generated] Review request for Microsoft.Insights to add version preview/2023-03-01-preview (Azure#23336) * Adds base for updating preview from version 2018-09-01-preview/examples to version 2023-03-01-preview * Updates readme * Updates API version in new specs and examples * Add metricsbatch swagger * Convert dataplane swagger to openapi 2.0 * Fix response type * Update response schema * Lint fixes * Unexpected token fix * Prettier * PR comments * Comments * Add resourceid to custom words * More PR comments * Fix model * PR comment * Small fix to example request * Address feedback from review * Update custom words * Small fix * Change descriptions for localizable string * Add missing description * More feedback changes * Small grammar fixes * Update endpoint name * Update interval description --------- Co-authored-by: gulopesd <73562152+gulopesd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TranslationFilter --> GetTranslationStatusesOptions
DocumentFilter --> GetDocumentStatusesOptions
as per #23088
Should we also change TranslationFilterOrder and TranslationFilterProperty? (DocumentFilter.. as well)
TranslationFilterOrder --> GetTranslationStatusesOptionsOrder seems a bit long and confusing in my opinion, but leaving them as is might also be a bit confusing. What do you think?