Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update .net SDK to OperationalInsights package-2020-10 #20090

Merged
merged 9 commits into from
Apr 22, 2021
Merged

update .net SDK to OperationalInsights package-2020-10 #20090

merged 9 commits into from
Apr 22, 2021

Conversation

dabenhamMic
Copy link
Contributor

swagger pr: Azure/azure-rest-api-specs#13782

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • [v] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@dabenhamMic
Copy link
Contributor Author

manually created the pr using this command: (my swagger pr was not yet approved - so using the generate.ps1 script generated the "old" sdk code)

autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/operationalinsights/resource-manager/readme.md --csharp --version=v2 --reflect-api-versions --tag=package-2020-10 --csharp-sdks-folder=C:\One\SDK_repos\azure-sdk-for-net\sdk

@JonathanCrd
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@check-enforcer
Copy link

check-enforcer bot commented Apr 7, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@dabenhamMic
Copy link
Contributor Author

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 20090 in repo Azure/azure-sdk-for-net

@dabenhamMic
Copy link
Contributor Author

@JonathanCrd could you please advise me what shall I do in order to promote this pr?

@JonathanCrd
Copy link
Member

Hi @dabenhamMic , please re run the command so the metadata text file is up to date now that your Swagger PR is approved.

PRs for this repo should be created once the Swagger PR has been merged.

@dabenhamMic
Copy link
Contributor Author

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 20090 in repo Azure/azure-sdk-for-net

@dabenhamMic
Copy link
Contributor Author

@JonathanCrd , the swagger is up to date, I'm unable to invoke the "/azp run net - mgmt - ci" command

@JonathanCrd
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

JonathanCrd
JonathanCrd requested changes Apr 19, 2021
View reviewed changes
Copy link
Member

@JonathanCrd JonathanCrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 breaking changes regarding new parameters.
Please fix those, everything else looks good to me.

...nalinsights/Microsoft.Azure.Management.OperationalInsights/src/Generated/Models/Workspace.cs Show resolved Hide resolved
...sights/Microsoft.Azure.Management.OperationalInsights/src/Generated/Models/WorkspacePatch.cs Show resolved Hide resolved
@dabenhamMic
Copy link
Contributor Author

@JonathanCrd , I finished updating your comments, I'm unable to invoke the "/azp run net - mgmt - ci" command.

@dabenhamMic
Copy link
Contributor Author

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 20090 in repo Azure/azure-sdk-for-net

@JonathanCrd
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dabenhamMic
Copy link
Contributor Author

@JonathanCrd , I re ran the generate.ps1 script, please invoke the "/azp run net - mgmt - ci" command and merge if possible.

@JonathanCrd JonathanCrd merged commit f7572fb into Azure:master Apr 22, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Sep 5, 2022
CodeGen from PR 20090 in Azure/azure-rest-api-specs
05fba73 
[Stream Analytics] Fix S360 for auto-scale feature (Azure#20090)

* add new GetStreamingJobSKus api

* add 'capacity' in 'sku' and let 'sku' out of 'properties'

* change v1 definitions to v3

* fix api version

* revert sku for create api

* Revert "change v1 definitions to v3"

This reverts commit a8687204a35bc2ce8d43bd3067da7a619216d6dc.

* add 'x-ms-identifiers'

* change operationId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanCrd JonathanCrd JonathanCrd approved these changes

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@bquantump bquantump Awaiting requested review from bquantump

@m-nash m-nash Awaiting requested review from m-nash

@markcowl markcowl Awaiting requested review from markcowl

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia

@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312

Assignees

@JonathanCrd JonathanCrd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dabenhamMic @JonathanCrd