[Event Hubs Client] AmqpConsumer Enhancement #19966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
christothes,
AlexGhiondea,
serkantkaraca and
JoshLove-msft
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
christothes
reviewed
Mar 31, 2021
| ).ConfigureAwait(false); | ||
|
|
||
| cancellationToken.ThrowIfCancellationRequested<TaskCanceledException>(); | ||
|
|
||
| // If event messages were received, then package them for consumption and | ||
| // return them. | ||
|
|
||
| if ((messagesReceived) && (amqpMessages != null)) | ||
| foreach (AmqpMessage message in messagesReceived) |
There was a problem hiding this comment.
I was just curious about the perf impacts of removing the conditional check before doing the foreach on an empty enumerable and it's quite a bit slower (though very fast in absolute time)
| Method | Mean | Error | StdDev | Ratio | RatioSD | Gen 0 | Gen 1 | Gen 2 | Allocated |
|----------------------- |---------:|----------:|----------:|------:|--------:|------:|------:|------:|----------:|
| ConditionalEnumeration | 1.132 ns | 0.0147 ns | 0.0137 ns | 1.00 | 0.00 | - | - | - | - |
| DoEnumeration | 5.490 ns | 0.0459 ns | 0.0429 ns | 4.85 | 0.08 | - | - | - | - |
There was a problem hiding this comment.
I tweaked to return null when nothing was received and added a check to bail out early if we have none.
The focus of these changes is to apply some of the Service Bus learnings to the `AmqpConsumer` for better efficiency and fewer allocations due to the closure.
jsquire
force-pushed
the
eventhubs/receiveclosure
branch
from
7d27886 to
e22387f
Compare
christothes
approved these changes
Mar 31, 2021
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to apply some of the Service Bus learnings to the
AmqpConsumerfor better efficiency and fewer allocations due to the closure.Last Upstream Rebase
Tuesday, March 30, 5pm (EST)
References and Related