[NetAppFiles] Apply 2020-12-01 api-version and recordings

[audunn]

Azure/azure-rest-api-specs#13388

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

• Please open PR in Draft mode if it is:
  • Work in progress or not intended to be merged.
  • Encountering multiple pipeline failures and working on fixes.
• If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
• I have read the contribution guidelines.
• The pull request does not introduce breaking changes.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

SDK Generation Guidelines

• The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
• The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

• Include updated management metadata.
• Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

• If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
• If the check fails at the Verify Code Generation step, please ensure:
  • Do not modify any code in generated folders.
  • Do not selectively include/remove generated files in the PR.
  • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
    Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

[audunn]

Note we had issues with generated validation code (not checking for null values) causes issues for SDK clients such as powershell. See: Azure/autorest#3585

The fix is to use specific version of AutoRest to generate the code this is incorrectly flagged as discrepancy with reference code and was also flagged in previous version see more details in comment here #18851

[JonathanCrd]

I found out what it looks like a breaking change in SnapshotPolicy,
Everything else looks good, just CI tests still need to get fixed.

[audunn]

@JonathanCrd The CI issue is due to the pipeline incorrectly assumes discrepancy with generated code and reference code, it thinks generated code has been changed. It has not been changed and this was an issue with last release as well due to AutoRest flags being used.

@allenjzhang can you assist with this issue?

[JonathanCrd]

@JonathanCrd Jonathan Cardenas FTE The CI issue is due to the pipeline incorrectly assumes discrepancy with generated code and reference code, it thinks generated code has been changed. It has not been changed and this was an issue with last release as well due to AutoRest flags being used.

@allenjzhang Allen Zhang (DEVDIV) FTE can you assist with this issue?

Yes, the reason they are failing it's because the version is hardcoded in the generate script.

Everything looks good.

[JonathanCrd]

/check-enforcer reset

[audunn]

@JonathanCrd I don't know of any other way to get around the original issue. The version of AutoRest used was generating faulty validation code, by not performing null-check before trying to validate nullable properties using the % operator Azure/autorest#3585

[allenjzhang]

/azp run net - mgmt - ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).