Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Made constructor of DataFeed parameterless #18319

Merged
merged 19 commits into from
Feb 2, 2021
Merged

[MetricsAdvisor] Made constructor of DataFeed parameterless #18319

merged 19 commits into from
Feb 2, 2021

Commits on Feb 1, 2021

  1. Updated DataFeed ctor to be parameterless

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    593e6d6 View commit details
    Browse the repository at this point in the history

  2. Added Create method validation; update failing when no data source

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    fa9872f View commit details
    Browse the repository at this point in the history

  3. Updated SourceType handling for Update method

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    bcd8bd1 View commit details
    Browse the repository at this point in the history

  4. Added UpdateDataFeed validation

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    e209830 View commit details
    Browse the repository at this point in the history

  5. Updated MinimumSetup Update tests

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    9af9389 View commit details
    Browse the repository at this point in the history

  6. Added name validation to update tests

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    81e8a61 View commit details
    Browse the repository at this point in the history

  7. Removed DataSourceType logic from DataFeed

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    e9675fa View commit details
    Browse the repository at this point in the history

  8. Updated Data Feed Schema to be parameterless

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    dbb9e87 View commit details
    Browse the repository at this point in the history

  9. Removed setter from rollup settings

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    13457b9 View commit details
    Browse the repository at this point in the history

  10. Removed Ingestion Start Time from Ingestion Settings constructor

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    83043e1 View commit details
    Browse the repository at this point in the history

  11. Added IngestionSettings validation

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    3212362 View commit details
    Browse the repository at this point in the history

  12. Made admin/viewers not settable; fixed admin bug

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    dde2cd9 View commit details
    Browse the repository at this point in the history

  13. Added admin validation; tests failing for some reason

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    e77fa1b View commit details
    Browse the repository at this point in the history

  14. Fixed admin issue

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    0dc1578 View commit details
    Browse the repository at this point in the history

  15. Fixed admin test issue

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    ed63a98 View commit details
    Browse the repository at this point in the history

  16. Using generic patch

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    5f3ee93 View commit details
    Browse the repository at this point in the history

  17. Updated docs

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    2a984ed View commit details
    Browse the repository at this point in the history

  18. updated test

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    2fb070a View commit details
    Browse the repository at this point in the history

  19. Addr

    @kinelski
    kinelski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    a182ca7 View commit details
    Browse the repository at this point in the history