-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#17662 [bug] add setters to LengthTokenilter #17694
Conversation
Thank you for your contribution nokternol! We will review the pull request and get back to you soon. |
Looks like I need to kick off some code generation process from Powershell. |
I ran Export-API.ps1 it created the gen code I believe the analyzer is complaining about. Pushed the change to the generated file but omitted the mixedreality as this feels related to other work. |
Hi @nokternol. Thank you, again, for your interest in helping to improve the Azure SDK experience and for your contribution. I've routed this to the team members best able to assist with review and guidance. Please be aware that due to the holidays, responses may be delayed. |
Thank you for your contribution and catching this error! The model properties are indeed read/write. This will be in the next release, though I'm not sure exactly when that will be. cc @tg-msft @brjohnstmsft If you need it sooner than later, please let us know. |
@heaths @tg-msft @brjohnstmsft I am indeed waiting for this bug fix in order to roll out a production solution so the sooner this fix is available the better. |
@nokternol we should release a new version in early February -- would that work? |
@AlexGhiondea I would need to check but for now I have broken of the functionality that relies on this code into a separate work item so I can process the rest. So that gives us a bit more freedom. |
* Azure#17662 [bug] add setters to LengthTokenilter * Azure#17662 Run Export-API.ps1 Co-authored-by: mark butterworth <mark.butterworth@carestream.com>
Apologies for my lack of knowledge of on how GitHub links things. UPDATE: I found the answer, clicking the 3 dots on the commit opens all tags associated which shows this commit was included in the 11.2.0 official release tag. Thank you |
The simplest approach to fixing the defect and it's the one used by all the other filter class with non-IList properties