Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17662 [bug] add setters to LengthTokenilter #17694

Merged
merged 2 commits into from
Dec 28, 2020
Merged

#17662 [bug] add setters to LengthTokenilter #17694

merged 2 commits into from
Dec 28, 2020

Conversation

nokternol
Copy link
Contributor

The simplest approach to fixing the defect and it's the one used by all the other filter class with non-IList properties

@ghost ghost added Search customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 23, 2020
@ghost
Copy link

ghost commented Dec 23, 2020

Thank you for your contribution nokternol! We will review the pull request and get back to you soon.

@nokternol
Copy link
Contributor Author

Looks like I need to kick off some code generation process from Powershell.
Not sure where that is and it's unlikely I'll have permissions to the resources required to run it.
Apologies, I was just trying to be helpful.

@ghost
Copy link

ghost commented Dec 23, 2020

CLA assistant check
All CLA requirements met.

@nokternol
Copy link
Contributor Author

I ran Export-API.ps1 it created the gen code I believe the analyzer is complaining about.
However, it also created the below file
sdk\mixedreality\Azure.MixedReality.Authentication\api\Azure.MixedReality.Authentication.netstandard2.0.cs
Which it feels is unrelated.

Pushed the change to the generated file but omitted the mixedreality as this feels related to other work.

@jsquire jsquire added Community Contribution Community members are working on the issue Client This issue points to a problem in the data-plane of the library. and removed customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 23, 2020
@jsquire
Copy link
Member

jsquire commented Dec 23, 2020

Hi @nokternol. Thank you, again, for your interest in helping to improve the Azure SDK experience and for your contribution. I've routed this to the team members best able to assist with review and guidance. Please be aware that due to the holidays, responses may be delayed.

@heaths
Copy link
Member

heaths commented Dec 28, 2020

Thank you for your contribution and catching this error! The model properties are indeed read/write. This will be in the next release, though I'm not sure exactly when that will be. cc @tg-msft @brjohnstmsft

If you need it sooner than later, please let us know.

@heaths heaths merged commit dbc26ad into Azure:master Dec 28, 2020
@nokternol
Copy link
Contributor Author

nokternol commented Jan 6, 2021

@heaths @tg-msft @brjohnstmsft I am indeed waiting for this bug fix in order to roll out a production solution so the sooner this fix is available the better.
Everything else is done and my solution is now holding up other business projects.
I appreciate that I cannot influence your timeline but it would be very helpful if I could know when the next beta build is scheduled for

@AlexGhiondea
Copy link
Contributor

@nokternol we should release a new version in early February -- would that work?

@nokternol
Copy link
Contributor Author

nokternol commented Jan 12, 2021

@AlexGhiondea I would need to check but for now I have broken of the functionality that relies on this code into a separate work item so I can process the rest. So that gives us a bit more freedom.

annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
* Azure#17662 [bug] add setters to LengthTokenilter

* Azure#17662 Run Export-API.ps1

Co-authored-by: mark butterworth <mark.butterworth@carestream.com>
@nokternol
Copy link
Contributor Author

nokternol commented Apr 15, 2021

Apologies for my lack of knowledge of on how GitHub links things.
It says my commit is not part of any branch on this repo which I'm assuming means it was squash merged and then the branch deleted.
@AlexGhiondea @annelo-msft How do I then find out what release sdk (nuget version) this fix is contained in so I can upgrade our dependencies?

UPDATE: I found the answer, clicking the 3 dots on the commit opens all tags associated which shows this commit was included in the 11.2.0 official release tag. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Community Contribution Community members are working on the issue Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants