Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication] - Common - Adding TokenRefreshOptions to CommunicationTokenCredential ctor #17597

Merged
merged 16 commits into from
Dec 18, 2020

Conversation

minnieliu
Copy link
Member

Two changes in this PR:

  1. Adding TokenRefreshOptions to CommunicationTokenCredential ctor
  2. Addressing the leftover comments from this PR: [Communication] - All - Rename CommunicationUserCredential to CommunicationTokenCredential #17553

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@minnieliu minnieliu merged commit 59a2698 into Azure:master Dec 18, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
…nTokenCredential ctor (Azure#17597)

* Rename CommunicationUserCredential to CommunicationTokenCredential

* Update changelog

* Update readme

* Update readme

* Encapsulate CommunicationUserCredential params into TokenRefreshOptions

* Renaming bearer test file

* Address previous PR's comments

* Update generated files

* Removing Identity namespace

* Fix format

* Update changelog

* Update Merge conflict

Co-authored-by: Minnie Liu <peiliu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants